From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5CC1C43458 for ; Sun, 12 Jul 2026 00:15:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3A8D410E3D9; Sun, 12 Jul 2026 00:15:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Hyh2165o"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 68D5F10E3D9 for ; Sun, 12 Jul 2026 00:15:42 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id A4726600FC; Sun, 12 Jul 2026 00:15:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3AAC01F000E9; Sun, 12 Jul 2026 00:15:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783815341; bh=TThjlVln2NNhO/CbQ1rM9tRSGRByI98U/e0wf21lG7M=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Hyh2165ogHBX3U6XLdx6dbXEvfFs1KQ8tawrgv6kRrYpBk4Ee1EK6Y1seKwbfCONj TuteNGvnR1Q0Xh+pbMtHXomtzEonZTLOQ1M2MessMmqAy2+rUvCqDcsIu8VyKWGG+k LtikaLz81LqpnMwV5XtHZiQ3/hMyTZOUVVcYX/kgNWQUhZRWLvG8ZMvdJX85I0CkDo GuN9grty9poRgxO4vrrAxWq2CmdceHMBRoKyRhyDGMLNzx8Ytpgdi0ffPqVs8RQXHj LhrLYWzs8oauMGcMYtvjImwPqB+x4ejGDfiFDS3wl5lq93RL6SNil1SxwWD+y0kXz/ wIvqk7MO1HtvQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH] drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T To: "Julian Braha" Cc: dri-devel@lists.freedesktop.org In-Reply-To: <20260712000823.2315810-1-julianbraha@gmail.com> References: <20260712000823.2315810-1-julianbraha@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 12 Jul 2026 00:15:40 +0000 Message-Id: <20260712001541.3AAC01F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The commit title and Fixes tag incorrectly refer to the Himax hx= 83121a panel, while the patch actually modifies the Ilitek ILI9882T panel. -- --- Patch [1]: [PATCH] drm/panel: hx83121a: fix unmet dependency for DRM_PA= NEL_ILITEK_ILI9882T --- commit e60d5f1c009ee5f39be0116d8f60dc041fbf06fb Author: Julian Braha drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T This commit resolves an unmet dependency by selecting DRM_DISPLAY_HELPER for the ILI9882T panel. > drm/panel: hx83121a: fix unmet dependency for DRM_PANEL_ILITEK_ILI9882T [Severity: Medium] Is there a mismatch between the commit message and the actual code changes? The subject line refers to the Himax hx83121a panel, while the patch actual= ly modifies the Kconfig entry for the Ilitek ILI9882T panel. [ ... ] > Fixes: defab7b01e08 ("drm/panel: hx83121a: select DRM_DISPLAY_DSC_HELPER") [Severity: Medium] Does this Fixes tag point to the correct commit? The tag references the hx83121a panel instead of the ILI9882T panel that is being updated in the diff below. > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > --- a/drivers/gpu/drm/panel/Kconfig > +++ b/drivers/gpu/drm/panel/Kconfig > @@ -374,6 +374,7 @@ config DRM_PANEL_ILITEK_ILI9882T > depends on OF > depends on DRM_MIPI_DSI > depends on BACKLIGHT_CLASS_DEVICE > + select DRM_DISPLAY_HELPER > select DRM_DISPLAY_DSC_HELPER > help --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260712000823.2315= 810-1-julianbraha@gmail.com?part=3D1