From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4DBDC44508 for ; Wed, 15 Jul 2026 08:00:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 08E4410E13D; Wed, 15 Jul 2026 08:00:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kemnade.info header.i=@kemnade.info header.b="O/a/emIV"; dkim-atps=neutral Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id 789DB10E13D for ; Wed, 15 Jul 2026 08:00:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description; bh=87clj23hFfpt9QBNepHjfZoYycZtPvLMabqLFhkG2z0=; t=1784102438; x=1785312038; b=O/a/emIV+TYW6W2pDmmSv6xtWqIGFwqnLbkKG7GQ7WVCQFActtUdq0PHFDfQRKI7ZF0FuM9IMtP 9gzopsXjkZG9t3KTXHHHMH1chxaOsY/wnlFzPLIGGQnhoFejm5mE2aGrpdkdOSTcwHcWtBpbmpLK+ Rb2UFQm1mIafdwArSP9UJU3VJw5KgoKVLwEfmXKIIkYNaxr/n1111Zw6aJ2bpTomHyEhYbl91YaT/ RvaCUUw5Xl6mTCQz90euvc/79ijQgo0L2S6em+Us6qsnafFeaK6EIrT3vDPuPjMRtZFw2OUMbMOcN yNs/jJPmOxGgxhEdnP6KZprqQMlXpTEWTMwA==; Date: Tue, 14 Jul 2026 20:46:36 +0200 From: Andreas Kemnade To: "H. Nikolaus Schaller" Cc: Grond , Stefan Leichter , Grazvydas Ignotas , Tony Lindgren , Ethan Nelson-Moore , Jarkko Nikula , Sascha Hauer , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , Aaro Koskinen , Kevin Hilman , Roger Quadros , Russell King , Daniel Thompson , Jingoo Han , Helge Deller , Jaroslav Kysela , Takashi Iwai , Sen Wang , Richard Fitzgerald , Arnd Bergmann , Srinivas Kandagatla , Kuninori Morimoto , Charles Keepax , Niranjan H Y , letux-kernel@openphoenux.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, kernel@pyra-handheld.com, mfd@lists.linux.dev Subject: Re: [PATCH 16/16] arm: omap2: remove remaining pdata-quirks for pandora legacy devices Message-ID: <20260714204630.0fd6bcb1@kemnade.info> In-Reply-To: References: X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, 11 Jul 2026 08:02:03 +0200 "H. Nikolaus Schaller" wrote: > After updating the pandora-backligt setup and removing the > omap3pandora sound system and defining related gpios by device tree, > we can remove omap3_pandora_legacy_init() and the related legacy > devices completely. > > Signed-off-by: H. Nikolaus Schaller regarding bisectabily: Do we create mess, if the platform devices via quirks are disabled? I am wondering how we handle this. If this patch goes together with the removal of the legacy drivers, then there might be a situation where neither the new one nor the old one is available? Split this all up? If sound discussion takes longer, maybe do the backlight thing alone? Regards, Andreas > --- > arch/arm/mach-omap2/pdata-quirks.c | 23 ----------------------- > 1 file changed, 23 deletions(-) > > diff --git a/arch/arm/mach-omap2/pdata-quirks.c > b/arch/arm/mach-omap2/pdata-quirks.c index > b947bacf23a37..aca7097a692ed 100644 --- > a/arch/arm/mach-omap2/pdata-quirks.c +++ > b/arch/arm/mach-omap2/pdata-quirks.c @@ -268,27 +268,6 @@ static void > __init omap3_logicpd_torpedo_init(void) omap3_gpio126_127_129(); > } > > -/* omap3pandora legacy devices */ > - > -static struct platform_device pandora_backlight = { > - .name = "pandora-backlight", > - .id = -1, > -}; > - > -static struct gpiod_lookup_table pandora_soc_audio_gpios = { > - .dev_id = "soc-audio", > - .table = { > - GPIO_LOOKUP("gpio-112-127", 6, "dac", > GPIO_ACTIVE_HIGH), > - GPIO_LOOKUP("gpio-0-15", 14, "amp", > GPIO_ACTIVE_HIGH), > - { } > - }, > -}; > - > -static void __init omap3_pandora_legacy_init(void) > -{ > - platform_device_register(&pandora_backlight); > - gpiod_add_lookup_table(&pandora_soc_audio_gpios); > -} > #endif /* CONFIG_ARCH_OMAP3 */ > > #ifdef CONFIG_SOC_DRA7XX > @@ -514,8 +493,6 @@ static struct pdata_init pdata_quirks[] > __initdata = { { "ti,omap3-evm-37xx", omap3_evm_legacy_init, }, > { "ti,am3517-evm", am3517_evm_legacy_init, }, > { "technexion,omap3-tao3530", omap3_tao3530_legacy_init, }, > - { "openpandora,omap3-pandora-600mhz", > omap3_pandora_legacy_init, }, > - { "openpandora,omap3-pandora-1ghz", > omap3_pandora_legacy_init, }, #endif > { /* sentinel */ }, > };