From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C71D4C44514 for ; Fri, 17 Jul 2026 09:08:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 314E810F4B0; Fri, 17 Jul 2026 09:08:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="NZdv50Dl"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 711F510F4B0 for ; Fri, 17 Jul 2026 09:08:39 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 5535B4063B; Fri, 17 Jul 2026 09:08:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35EEA1F00A3A; Fri, 17 Jul 2026 09:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784279319; bh=bKfzN4EqpiMbnxR9DAJnBuN7lXi1koJJ0p28NYfMO3o=; h=From:To:Cc:Subject:Date; b=NZdv50DlbHZyuy6BjoPlyaM99G6qYR29gTIr9Gq20rgr6deIlatrV58vnUSN3W1QZ UGuOG1KAl5a/dL8TCkmixyuGLiH6uFaZQTKJBK6N9khEI5HE+tOnh/0vkB96YdQS3l dXzePX/2RfsxvdbAZ/1kEbzjZeolPUEkpi+1dXHDXILtQDe7kFeLg+puo5XL30CcDX E+cPXTAQlmVBDQpXA21RUUPBftOLC9foG+HITCnd0WAT+56DpKVvi7HJ/7mFGf7s6g HYCOlnggoBbJI5aMVjIu1QG4wzlzb4GC493S8JkFTcOKmWJedMS7G1yt+nzLZUcli5 JwrodjBjsp9Rw== Received: from johan by xi.lan with local (Exim 4.99.4) (envelope-from ) id 1wkeYe-00000006qIU-1aMZ; Fri, 17 Jul 2026 11:08:36 +0200 From: Johan Hovold To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart Cc: Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Johan Hovold , stable@vger.kernel.org Subject: [PATCH] drm/bridge: dw-hdmi: fix i2c adapter leak on probe failure Date: Fri, 17 Jul 2026 11:08:19 +0200 Message-ID: <20260717090819.1630965-1-johan@kernel.org> X-Mailer: git-send-email 2.54.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Make sure to drop the i2c adapter device and module references before returning when detecting a malformed devicetree during probe. Fixes: 80e2f97968b5 ("drm: bridge: dw-hdmi: Switch to regmap for register access") Cc: stable@vger.kernel.org # 4.12 Cc: Neil Armstrong Signed-off-by: Johan Hovold --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index 17d5caedb32e..9eb6cf8a321f 100644 --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c @@ -3389,7 +3389,8 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev, break; default: dev_err(dev, "reg-io-width must be 1 or 4\n"); - return ERR_PTR(-EINVAL); + ret = -EINVAL; + goto err_res; } iores = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 2.54.0