From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CF7EC44507 for ; Fri, 17 Jul 2026 08:42:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75A3310E426; Fri, 17 Jul 2026 08:42:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="sfurYEE6"; dkim-atps=neutral Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0723410E426 for ; Fri, 17 Jul 2026 08:42:42 +0000 (UTC) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-476d8e647e9so6922698f8f.0 for ; Fri, 17 Jul 2026 01:42:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784277760; x=1784882560; darn=lists.freedesktop.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=x1bNr8ApLUuasJ6rLo6oRgqpfU7n7a0nEcTyafySNYU=; b=sfurYEE6ZFzW0aaurCTsoT+pnogdwyoVhAiAPfMsbyE80RQVYiXqu0kRqejFYSfAKC 0JBttl8WrPpnGqwEEMnfYpygeZ4Pl+SsxJK7fuzh4m6IP67fTAJy5xCqynsN5Mm7bkNw VTQP5UFyZge5ZmWEdzdGRZs7aMOJicm6AUWAN97MC1qydC+Dpmi6Z9w5C8NM5jMKf3AM qUz6VAYwPw/2Ba1NFfvIw05+noDKG/dnfRk7CBlkoq457jDN1A3eT7NqQwbTgQrdfybA y5/fIYfDpOPVC/RAYpa7cNT5QI897UdnAct5VI44FlFYYt6Niqxd6kvq7aEr6pj+Bhqr o1Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784277760; x=1784882560; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=x1bNr8ApLUuasJ6rLo6oRgqpfU7n7a0nEcTyafySNYU=; b=VcuGsIVzLzmlmeHX6/pRG/Hh7lwBMlwfdgLYgGJcqqVA8wAPQySbpXFlHXKfQAsZQC 1uTMu2HMZkgDhetqRfoaGFSVPRyCDz/JoLshzThcEhKs5Ezd4UckE+23JvJrAP6ku8OK SEYP815WgZV7bmgC9jd9lkbdb4cBVzrOUQqDC6B/qTth/uqb4TeYhX9X61/ewXfYVAla C/FAVesMLZBNPclDrjZd37xEAPIFXe9WeXLbOM1Ho4orZbyWiPWYawLFc4BX+hA+SnnY X6Dmz3ErtmahxPlgLpKI9U/Mo4yhFkWYwNnVYj53P6Aup8K93iHpQo6Cz/enP+THjA0S U7bQ== X-Forwarded-Encrypted: i=1; AHgh+RolXVpqYGOwtMbNyYKvNjI/JWTs29ilqVQAcojly+IrDSY6H397+f/OqvtHg4yrkLw9PoKuzfFwL7Y=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yzdbl20/By9rhgDR55VkBwJn4v1lkvBgHZK56t0HOXi5GUDP2hh acUF25+7nvVXFvGbUtkRPwGMQSguMyPhbHwpLFUj8T1USlHrYeFmplM6 X-Gm-Gg: AfdE7cm3RPbCt+wLPc2ZBsA86uD85KlbBvgtIhHGREY0xP1CAXKz6DjP7tUExKIjmAe eFAN3U7fONDVdpaNzgwBAKoqs1wZpmcg16tWG2N2ToYbtoWhlnXwA0t3vMWkgdpxSqqPLGIw3+H Rzq61MUPxP7ox9XNBCy81kVC1r2TtSx6qdeemykorMjQU7yWW+i07TmA9Q4onNbhKda/6V+gbWY aFvs7pnbjHqTy/rltAyj6FAIaKKBPR6s0KXreX6zA461vCJR5XBb3vv31wjzDWkSFlS6PaGZBlg Desv4AyOShJr4cyocyuzY57dTEw/iA89ABb52BUneABsYVVwXUd5nX5J6O48w/XAr7UKl5ilUsA Rvyx3MXrEA+MefLp2q1mBPN2Y6WUtfkdlglerO9e9URgqEp/HA2nPK7CPNiWpNhSzL13YVXFi62 m4oOyao4YJQnepYMSamPEmmwmI8M5junf8YovddE8= X-Received: by 2002:a05:600c:3107:b0:493:d305:b8f3 with SMTP id 5b1f17b1804b1-4954a3d6462mr20532115e9.3.1784277759663; Fri, 17 Jul 2026 01:42:39 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4954a2692a3sm28806635e9.0.2026.07.17.01.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 01:42:39 -0700 (PDT) Date: Fri, 17 Jul 2026 09:42:30 +0100 From: David Laight To: David Matlack Cc: Matt Evans , Alex Williamson , Leon Romanovsky , Jason Gunthorpe , Alex Mastro , Christian =?UTF-8?B?S8O2bmln?= , Bjorn Helgaas , Logan Gunthorpe , Kevin Tian , Pranjal Shrivastava , Longfang Liu , Mahmoud Adam , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Sumit Semwal , Ankit Agrawal , Alistair Popple , Vivek Kasireddy , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, kvm@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v5 0/9] vfio/pci: Add mmap() for DMABUFs Message-ID: <20260717094230.21829508@pumpkin> In-Reply-To: References: <20260715174737.15287-1-matt@ozlabs.org> <65ba06e7-4c54-437d-9fbd-632c0468f66d@ozlabs.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 16 Jul 2026 21:23:22 +0000 David Matlack wrote: > On 2026-07-16 03:51 PM, Matt Evans wrote: > > Hi David, > >=20 > > On 15/07/2026 19:12, David Matlack wrote: =20 > > > On Wed, Jul 15, 2026 at 10:47=E2=80=AFAM Matt Evans = wrote: > > > =20 > > >> This is based on v7.2-rc3. > > >> > > >> These commits are on GitHub for easier browsing, along with > > >> "[RFC ONLY] selftests: vfio: Add standalone vfio_dmabuf_mmap_test": > > >> > > >> https://github.com/metamev/linux/compare/v7.2-rc3...dev/mev/vfio-dma= buf-mmap-v5 =20 > > >=20 > > > It'd be great to have this test upstream. I'm happy to review it when > > > you're ready. Looks like it just needs to be redone to use the VFIO > > > selftests library and kselftests harness. AI could probably do the > > > conversion pretty quick :) =20 > >=20 > > For sure, I'd intended to catch up with you on best approach here. :) > >=20 > > Aside from the organic structure of the test (the open-coded VFIO > > device/group setup/init needs to go), the main issue is that it relies > > on a hacked/out of tree QEMU "EDU++" device with a second larger BAR > > (containing freely read-writable memory). A subset of tests run with > > the in-tree EDU device, but coverage is too low. > >=20 > > The desirable properties are: > >=20 > > - Having a BAR that is pure memory (all locations present, writable > > without disruptive side-effects) so that mapping aliases can be > > constructed and detected. This is good to test things like non-zero > > vm_pgoffs and VA space presentation of physically-discontiguous DMABUFs. > >=20 > > - BAR >> hugepage size so we can eyeball huge mappings work (or better, > > mechanically test for them). At least 32MB would tick this box for 4K, > > 16K page systems. > >=20 > > - Something QEMU supports*, so one can run the test in a VM/TCG system. > >=20 > > There were some real device models in QEMU that could be used this way, > > but needed a fair bit of setup; I didn't want to rathole > > vfio_dmabuf_mmap_test on including a ton of device-specific code for > > some video card or similar. > >=20 > > I'll dig more for a simple target that provides these properties -- > > obviously it would be better to point this test at an off-the-shelf > > device (including silicon!). And, proposing EDU extensions to the QEMU > > folks may be useful (there're uses for a better EDU in other contexts t= oo). > >=20 > > Since this test uses MMIO for a specific [class of] function, my first > > thought is it should be another VFIO driver-type test sibling of > > vfio_pci_driver_test. For example, we could extend the driver-type > > tests' backend struct vfio_pci_driver_ops for functions capable of > > providing a Big Memory BAR, like QEMU EDU++. EDU can also memcpy, so > > could also support vfio_pci_driver_test. > >=20 > > The spirit of the device backends hiding setup of a complex device is > > handy, and it's plausible that several backends could provide this "big > > memory BAR" service. What do you think, any concerns with extending > > vfio_pci_driver_ops like that? =20 >=20 > I wouldn't recommend leveraging the driver framework unless absolutely > necessary. It makes the test harder to run. >=20 > The biggest issue I see with the proposed properties is being able to > treat the BAR as memory. That obviously will depend on the device and > may require device-specific setup. If we decide that treating the BAR as > memory is truly required then using the driver framework is the way to > go. But I'm hoping we can avoid that requirement. Could you run a test where only a known part of the BAR can be treated as memory? A large BAR is likely to have some areas that can be accessed as memory. David >=20 > Instead, I think you can get pretty far by inspecting /proc/pid/pagemap > to determine if the mmap() set things up correctly, without actually > accessing the BAR. You can use /proc/pid/pagemap to look up the PFN and > PAGEMAP_SCAN to detect huge pages. >=20 > With that requirement gone, then all you really need is a device with a > large enough BAR. And even that it not a hard requirement. I'm sure > there are plenty of test cases that could work with smaller BARs. The > few tests that want to exercise huge mappings can inspect the device BAR > sizes first, and if they're all too small, SKIP() the test. >=20 > If you structure the test this way, then it's easy for the test to be > used. It can be run against any device for the basic functional > coverage, and can be run against a device with a larger BAR for full > coverage of huge mappings. >=20 > Does QEMU emulate any devices that have 32MB or larger BARs? >=20