From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75C2AC44520 for ; Mon, 20 Jul 2026 15:40:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D0FF210E1CE; Mon, 20 Jul 2026 15:40:53 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="IAO9xvIL"; dkim-atps=neutral Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BEDA10E1CE for ; Mon, 20 Jul 2026 15:40:51 +0000 (UTC) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-47f59f25ec4so1164784f8f.2 for ; Mon, 20 Jul 2026 08:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562050; x=1785166850; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=IAO9xvILqkPUJ8bciUd5sm3YGzaCI5KZ1rzbX4TAfvzYzN7wHrRbG2ABEd4WsfdrQC o43qG0IMhaIF+bBrkoqH644len5zgTHiJlbieWOR6MTjj6Yd9WlpYNbj8aV5HRf23wnW dABkHR4wiwaN9gRjmjUtuMqVcqa05pRI7Ii0zjxXzx9wNLMBHS3uPn+jUdB5Wqou17hN GzNwvuKihDsW2uZ3vE9xKg3/P8IYeL0zpSwC5IS+GIYGp88AjnSPkKZwEVfMTozH3N2c j+TLTMkZP2j3awT5blR9EwT6MN4z+kcIy6yGVa0H1E9XWDF+vrI7k7wS2DKZLId3sQXv /25A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562050; x=1785166850; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=XyYn7XebW1XE8vBENDzZtPaPly9Do87l9WwImEGfz+U=; b=rcY4MTYOBkUFsupianEh6d/ZcLyHk8b4UJR0x0TE8Bz07LF+nSHC3MzkznDRNy0xOT XI5aIwvur0+RLZUpdLr1B5bifuy8GZivKRLhxu5DophtDSq0J3ZYat1OKYU0yQp+IPhT e2ZzXx4mRh7ytWa3mQ+K2x1Gc9jlR66T9baJRIHXru09mgxummKCSk7NTv72dqY+f+nT aWcaTH6rQyzULGd2vmPStixM9sAJLapncMyYG4JH6V1IK6kdVPnvVTbpU/Jyi6cnciL1 mspnVO1bEaUOQaUuF9m+quKA9cKOxVFNXqcYq0AhPFIGswIN4nS5+bwsY3wmXZP93Umt Zc0Q== X-Gm-Message-State: AOJu0Yx8luL7PeWO/abttZAW29JlRrotmFarV6IO5TLFMXptAp39c0Tp GG8oNaUWgppleuWtOM+mA7N7F3hCXNI6QE4t72jMkzhrxZYs8zFqUmir X-Gm-Gg: AR+sD10+cakvUIRI/KZXMrs5ldX+ltqXkbRskMRdwrjV8JhVorrIc/IvT3MiG+mYa0U g85tGbVNlYxML9DDs3YccKAySOSl48H6UlTa+Ad1nYRyr1ec3nmwprbzAxWNX2vBi9Xbd8U1O6f 99vutZvI+48vovqybiPyUJ3cbTlaA8pFjAhKUbaG9EQia6O9RlGDOiuPFECeZg25NlxAg+MDoJg QvNFyL46ls8YDETrpYG9cCvLXQJDi0Grb44gnfGEbsGzncIsVo52NGOS05zYs/QI+oClWW5BxY4 tUhsri1AWB9DkGgTe+EAfN9L2uYMCvbkzolwNWJO97hrqsQtnkcuS0AfEvD1SqcX4kJd+DHXppe JZmzrvCrGWcmjxrFoMx18KE2JiZDD5sjXhe/ZVKaXOwk5KQx3pQTLH6PlZiMAG4Y5Ex+1w2h6ft jqK0wWUwCjvg== X-Received: by 2002:a5d:5885:0:b0:46e:1815:6a83 with SMTP id ffacd0b85a97d-47f62318f12mr16050393f8f.29.1784562049630; Mon, 20 Jul 2026 08:40:49 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.40.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:40:49 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:33 +0200 Subject: [PATCH v2 01/15] drm/exynos: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-1-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/exynos/exynos_dp.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dpi.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 11 +++++++++-- drivers/gpu/drm/exynos/exynos_drm_vidi.c | 13 +++++++++++-- drivers/gpu/drm/exynos/exynos_hdmi.c | 14 ++++++++++++-- 5 files changed, 54 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index b80540328150..957382223956 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -24,11 +24,11 @@ #include #include #include +#include #include #include #include #include -#include #include #include "exynos_drm_crtc.h" @@ -79,6 +79,10 @@ static void exynos_dp_nop(struct drm_encoder *encoder) /* do nothing */ } +static const struct drm_encoder_funcs exynos_dp_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs exynos_dp_encoder_helper_funcs = { .mode_set = exynos_dp_mode_set, .enable = exynos_dp_nop, @@ -95,7 +99,12 @@ static int exynos_dp_bind(struct device *dev, struct device *master, void *data) dp->drm_dev = drm_dev; - drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_TMDS); + ret = drm_encoder_init(drm_dev, encoder, &exynos_dp_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); + if (ret) { + drm_err(drm_dev, "Failed to initialize encoder\n"); + return ret; + } drm_encoder_helper_add(encoder, &exynos_dp_encoder_helper_funcs); diff --git a/drivers/gpu/drm/exynos/exynos_drm_dpi.c b/drivers/gpu/drm/exynos/exynos_drm_dpi.c index 0dc36df6ada3..de4a80158746 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dpi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dpi.c @@ -12,10 +12,10 @@ #include #include +#include #include #include #include -#include #include