From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D029C44515 for ; Mon, 20 Jul 2026 15:41:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CDC1910E99C; Mon, 20 Jul 2026 15:41:33 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="RTI/b+At"; dkim-atps=neutral Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by gabe.freedesktop.org (Postfix) with ESMTPS id ECADF10E99C for ; Mon, 20 Jul 2026 15:41:29 +0000 (UTC) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4954df200ddso17132645e9.0 for ; Mon, 20 Jul 2026 08:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562088; x=1785166888; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=RTI/b+AtrC85L4XzwZISdrgddsJgCJURW6ywywg5rQcL/YtfRvxggFOMNQtx4vjHdR 6Ybnq8e3OH33H6/0sDdxOTMJJCE4HiVIbnG+p2LaCp+CzR/Ap3yNW3bsxriIb8Azcsu4 FcciUH0w/BK9iwdVwdLBM9GV3BeAfrmqAsGzDBLbOfvT5gKWKwIGY4BtxpIxG1GiHbDk q0nchP1M/7ZVmQiCs+CfEg2MNn8awQfq2tOaZsgRVR6Aazb35iA/Vyj63k7nUDUPYt6e Csa+cjJ37mST3a4sCE0c1IG8qrdsR1A0Xa7WwHfLGPUH67iGpw4hh45ZhnttI9xCsFbR 1uhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562088; x=1785166888; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UCTzuFV7eFCGxIzO9ORcmzHtSM3Ggk/jrKBR0xDgYaA=; b=EkOscmNxgn670t/qTkcas3Pj3m3tJsZmVoywMCkfDBaD+go6RXnNezInazQD+Gz+p8 0iHWApoLgfrV2VQBxRn9VoED3UBXCkoYON779qhIAvCUA6pS3dP8rzL1p8S9S75I3p4b lphy7HVyANCCVbfsohrSHyVHDQYl7cEtDzHMX6kz3HJk6wdLnPS7P8crbYYsGqHFgkrM MWCqJN0DhPRVp5CZK9veq0ndiv1PdX9HHfg8tHjaxQsdHsL6GkfpMvGDZo1x/3fk4sjK tOJkReJZulrl+JQrvGH0/uIgJA3M2mzPGXH8zbf7JKFqnjePhDGQJpYVprqwciiQmvQP IqOQ== X-Gm-Message-State: AOJu0YxwQBKBCQ5ujKxqjenfKIJFlTPnuhW8NHRy7zVUbvi5jmnfUIB0 27R8qzocoZXPePIXO4SNzD2k0/fwRPySjkRm5MpItxV0/1gV9UHFnzi6 X-Gm-Gg: AfdE7ckEQBGt3UN1B5mm8dqI0/hZ4+Lk2nA5Zp3GHOZBBawDD+SyNPGiZV61auNHce7 A1VH6jFP2hD+CSVb8U6aPrXvJZl/sAmjTPnruVQyEukyMC4uSfERYAmjsxboqujKI2+hPCDAcNq CwfnAyESeboMRU350fbKLx/Qb1pI449/BEJBdGeREHSUXOp67BZ3hUEbHLmv6JDl5mjKy7Mid24 Lb3CavDDkN2zKLn7EWSRMp+qSMuM2exyG4dDmQB1qOkxS2Bc5f/Sh06UIMEzD857TEyddWZakog JV17MCmgR9ilHSaq/e/ASfkWdVfZov7gQo0k8pYYjXfyX9VGIj9uwITBA1tQgGdEmnC+m8BZddY aAxI3uv3r4SvhIxPUx51Xj01m/HZ33C1xeLKBFkYKYpj2PlmMEHqThr/KJepxBN/FZ4yKf36303 +BL7LZ+qI6jadbWQBgiPGu X-Received: by 2002:a05:600c:1d1e:b0:493:b6ee:fcb7 with SMTP id 5b1f17b1804b1-4954a3f39ffmr153406895e9.14.1784562088052; Mon, 20 Jul 2026 08:41:28 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.41.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:41:27 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:43 +0200 Subject: [PATCH v2 11/15] drm/hisilicon/kirin: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-11-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c index 15042365dec0..62c5bd3277da 100644 --- a/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c +++ b/drivers/gpu/drm/hisilicon/kirin/dw_drm_dsi.c @@ -20,11 +20,11 @@ #include #include #include +#include #include #include #include #include -#include #include "dw_dsi_reg.h" @@ -687,6 +687,10 @@ static int dsi_encoder_atomic_check(struct drm_encoder *encoder, return 0; } +static const struct drm_encoder_funcs dw_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static const struct drm_encoder_helper_funcs dw_encoder_helper_funcs = { .atomic_check = dsi_encoder_atomic_check, .mode_valid = dsi_encoder_mode_valid, @@ -708,7 +712,8 @@ static int dw_drm_encoder_init(struct device *dev, } encoder->possible_crtcs = crtc_mask; - ret = drm_simple_encoder_init(drm_dev, encoder, DRM_MODE_ENCODER_DSI); + ret = drm_encoder_init(drm_dev, encoder, &dw_encoder_funcs, + DRM_MODE_ENCODER_DSI, NULL); if (ret) { DRM_ERROR("failed to init dsi encoder\n"); return ret; -- 2.54.0