From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 68015C4452B for ; Mon, 20 Jul 2026 15:41:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C730C10E99D; Mon, 20 Jul 2026 15:41:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="L4Ko7IV6"; dkim-atps=neutral Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9418D10E99A for ; Mon, 20 Jul 2026 15:41:33 +0000 (UTC) Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-47f3b39f2a1so4905628f8f.2 for ; Mon, 20 Jul 2026 08:41:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562092; x=1785166892; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=glDDRAcdG2z8u1IQ6JIBLAUYK0TMezc+/0A/g0HZvjw=; b=L4Ko7IV6Xvyf45AaZq8CQMiOinY0A/cL1opJpgxeUIQi2ZkgblLguR0gWeToyhPzgl gvWF0MKhYD5OGeA7/pv9tPNI2hK+iKYH2QBfafmc43x+WPdZeTR/IJn/St/5kHsF4ql9 u0XTILEsas6UPL+4lLJb3z529BW0sg2ZbI8icj4raJlwmQXuM+JQYVxTB93JQsqsTl2G 8bHaWjIxn4dvS3qA6CjSChEAu/4fF7O3duiicErovp2U/yrE6cJ1FruvKkFoYFCMB02L UsTegVdLiG3GhfCQfMMp5Ej9dDhtJbCFSiLX2LOx9ZkMnuANX/hDIdWI7RwGGly7Zc88 mniQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562092; x=1785166892; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=glDDRAcdG2z8u1IQ6JIBLAUYK0TMezc+/0A/g0HZvjw=; b=jE5wbBrpa7w40YJv2kQgy2Rd4Qpqi1UmUVv2z/zTe+sIdrxjPDgfmW3g0SSxzk76Pl cfzkwkLsuOAxKB8CESEfV9oOkw7Hg6RUXxogQyhwMgC1hTyZbRzPNXAcut4zARRYABUL wnIUXJC8Yz5IoLs7sbVdHZBSqwOpaNWHychD+u4SOXUEPfIheCU/naH4YkMI2dpbQHCw da5B7sIKzsuCGqmU4XRAEizjsFQYictaSDp1iruiaanDx7P7VzTOnmsEivuUXEZGmT7I 9B5idj6fLtlxhMwkwhTPrNHDFu1X3ZdCCxeVL92v+oO0Lyk+j9LhwkHzcLRYWvC52P1R xO1A== X-Gm-Message-State: AOJu0YxRVkE09YkajFXm5UCy4TYO77Qu90AdCCd7HBCrcrYPlTyPRXp5 R4UjgjK1/o2exs4rySWbTOMSLUc+PBL7/Th0dwA3HMF12BH15gClZiMu X-Gm-Gg: AR+sD12z4e2rG7/YnJhvr7EBun0glnfO8P6+j01ac0wCYcW79QjJpUWMAFxCf/mNNy2 u51cUKPPZqjhpNzQwZs4EE84W4RGzWj17IXJs7q4u/hSKDK3tFiFVHozTNbfBxbAqsZhv7T21vo 0U49K8P+0YPTYJtDLCOdhYNEDS8vvqfsvRvC8s9d8SaSQTfmD2O9Da634HTaMs+xk1dmSGOJ0Xl yL0qn4qDvIMj0EAvfcdwuCalCW9PS39I3bjWj3XCidB/tatb8W8H7VPCaqqSJod1s3tLkT8slWi B62YwdmM0zBL1hu80asc5oITNSbkZrAnDYPWhKEGAM1j4/2UEGUa0zLNCjcC7Rjnb03O7FAxjSh dOUtz8QpKDERcOYxvwHUWTTev0Z/86pkVtQnId3oaajClQa4X4MnQadMk3OLuaLfgJ1Zomojdff eEL9+tmbb7nw== X-Received: by 2002:a05:6000:29c8:b0:47f:699b:a80c with SMTP id ffacd0b85a97d-47f699ba8a2mr8405565f8f.52.1784562091837; Mon, 20 Jul 2026 08:41:31 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:41:31 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:44 +0200 Subject: [PATCH v2 12/15] drm/arm/komeda: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-12-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/arm/display/komeda/komeda_crtc.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c index e8cb782a6f8e..719568d9f7c2 100644 --- a/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_crtc.c @@ -11,9 +11,9 @@ #include #include +#include #include #include -#include #include #include "komeda_dev.h" @@ -635,6 +635,10 @@ static int komeda_attach_bridge(struct device *dev, return err; } +static const struct drm_encoder_funcs komeda_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int komeda_crtc_add(struct komeda_kms_dev *kms, struct komeda_crtc *kcrtc) { @@ -658,7 +662,8 @@ static int komeda_crtc_add(struct komeda_kms_dev *kms, * bridge */ kcrtc->encoder.possible_crtcs = drm_crtc_mask(crtc); - err = drm_simple_encoder_init(base, encoder, DRM_MODE_ENCODER_TMDS); + err = drm_encoder_init(base, encoder, &komeda_encoder_funcs, + DRM_MODE_ENCODER_TMDS, NULL); if (err) return err; -- 2.54.0