From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 212B6C4452D for ; Mon, 20 Jul 2026 15:40:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7BF3B10E1D2; Mon, 20 Jul 2026 15:40:58 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Fs8DAW5V"; dkim-atps=neutral Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D8F210E1D6 for ; Mon, 20 Jul 2026 15:40:55 +0000 (UTC) Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-47f703a9e5dso509207f8f.0 for ; Mon, 20 Jul 2026 08:40:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562053; x=1785166853; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Pvez7dBBgFzTEWul+X0zgtK0IubmPdgVdOv0lVVEMOs=; b=Fs8DAW5Vu28Hp2+CD+2BOz43BXGs+LuMHFn2gY5Z8MTa6gqQL8HykqZnWfNWowNtmH h+/q8iQeMaJRyN2t9C8j1FMJMJ5BIW5Q5+s6eBn/ZDsjJ3sE3QEBMKQlylEtfeSIrA9j thxf1PSuP9UNUMVW0nlKj00BK1hvFOCRYLF2+e8ekgDZRtQIEQUxE7380e+UtDmXu88C d4jq0tG2+hVm4TCn+2h/f7+g1FKEeQqodyePOBMtuotTNTGvhHz7GgvglcxhZADc5SKy RoKQRAmQwIu8OWQsBdfBkN1VDi0iWUEk74lQaU4FWHY6yB3Z9PXShemTTAx9eHDNiXuq tDlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562053; x=1785166853; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Pvez7dBBgFzTEWul+X0zgtK0IubmPdgVdOv0lVVEMOs=; b=WMzMpwbaGFx7iAJykT/riKbIkvB/x+wCCc9FutI9XN9ep85sKCag9TPXpDsTy5ZQZS hZmHY8fNv4ijPZSeY2N6p141W1emjI953MfYgJAmwDPY14ty/tQ4IgLTv8CDWgUuG1eT tMjR5NdUVuQv7S8sSThp/rjNafNLpFkkS792JghJIy2uxcRPQDsTXjIrqzZH2kRQjphq JKlPcIH9ZbJwDrvDN61zc4MljB3VGHPOlPz/dcoiVQAQ4U+EezOsKaQVRmBy7ocnkwu1 CiB40tfdmLdoAot0prn4NBrNTTauBe/JhAayEiZIBE35e7pJLtLb92jyjWjI483olnWg lpfw== X-Gm-Message-State: AOJu0Yxb/Bfv9CHVNQpKlaeDQKXiRiowHyEXKvGmAQsfT+4uwBA6xkEc qkq1hUlUfKtA9vDYlM60nEDEc/yK4X8QEG+QQvYXcnrbb/RwTatGlhUI X-Gm-Gg: AR+sD11wMsP+0DvcpA8Ckrpg0XSuC83ACypSIy+Wv7w5UuVtmmbpJUSpfCYFGrY7t87 Kb8AqRG5J9CHNR5P0T4bTlF0yvmWqkUeKxmu9lzHZSF09sXbidYFm/IYrWYD5XgZeg/z3MxWVgN QnhJ7jSbz8AqS1clFro5cbfjr9f3E9vZfiAmk4DTCjtqGh2nujO76LyMAb6YEOW+UGSyA80BwZl zNcWs0L2z8CjxugREEswxE23++U2/L9d/cV9s7Q69bO2V705ziJ1VhD6mdJ0a03JzdGDodh1tjq Oy6msldtt07RS5h9b8570MSu/+OLATyEVzUhf8j5f1I8ePINc/cGHNiUvPai2qh++zFIvE9022s 4ec7FeBn1kobnowTap2GAOhSv+0SYc6Z/VJDgcdWPqsmcBHMnIYFbJJM1gP/5E18sV76J/ZIr9a VPwyPNCpMHvQ== X-Received: by 2002:adf:f604:0:b0:475:f0f0:9ef6 with SMTP id ffacd0b85a97d-47f6233f338mr13274205f8f.59.1784562053525; Mon, 20 Jul 2026 08:40:53 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:40:52 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:34 +0200 Subject: [PATCH v2 02/15] drm/xlnx/zynqmp_dpsub: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-2-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Also check the return value from drm_encoder_init() to avoid silent failures. Signed-off-by: Diogo Silva --- drivers/gpu/drm/xlnx/zynqmp_kms.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_kms.c b/drivers/gpu/drm/xlnx/zynqmp_kms.c index d5f922450565..ac9197e026af 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_kms.c +++ b/drivers/gpu/drm/xlnx/zynqmp_kms.c @@ -29,8 +29,8 @@ #include #include #include +#include #include -#include #include #include @@ -417,6 +417,10 @@ static const struct drm_driver zynqmp_dpsub_drm_driver = { .minor = 0, }; +static const struct drm_encoder_funcs zynqmp_dpsub_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub) { struct drm_encoder *encoder = &dpsub->drm->encoder; @@ -436,7 +440,13 @@ static int zynqmp_dpsub_kms_init(struct zynqmp_dpsub *dpsub) /* Create the encoder and attach the bridge. */ encoder->possible_crtcs |= drm_crtc_mask(&dpsub->drm->crtc); - drm_simple_encoder_init(&dpsub->drm->dev, encoder, DRM_MODE_ENCODER_NONE); + ret = drm_encoder_init(&dpsub->drm->dev, encoder, + &zynqmp_dpsub_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); + if (ret) { + drm_err(&dpsub->drm->dev, "failed to initialize encoder\n"); + return ret; + } ret = drm_bridge_attach(encoder, dpsub->bridge, NULL, DRM_BRIDGE_ATTACH_NO_CONNECTOR); -- 2.54.0