From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 570D2C4452B for ; Mon, 20 Jul 2026 15:41:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B453710E4A0; Mon, 20 Jul 2026 15:41:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="Uwo/ZW8q"; dkim-atps=neutral Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8815310E99A for ; Mon, 20 Jul 2026 15:41:18 +0000 (UTC) Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so78722535e9.0 for ; Mon, 20 Jul 2026 08:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562077; x=1785166877; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=3qoMRiXvV6BHSei+lkJBYDW1cqZXXpht0BCmlOitIE4=; b=Uwo/ZW8q6+VntXR6FAKPnGyrWTSIUQ0YOST9v8QADvRns/TU0ipaSTCSaBFqh+YpH8 Y42aRqU66m0hcPXyODWWlyPZKZk+UinypdWZkVPn66AatAVR11OX80kZuYsSTF0syOxa rcbDMi4lcKP/5wplnYQCz6l5Pqsr8tBkxNK6VGNeauSq3xtAI4kuasSUKPliG9QhDiuU 8Irvf5dvznnpcwdBHCstQUVURGVIpUY7B+NB0JaKoqiCsIJ6F9zJsuHm7hEOcbD/FGQE nM1NmsLvkgzDR9z6NbcV0GWxOGgjWwmom7NAUJMwQVtamYb+i3uU/mfJwWUdHyKA+1lB 5HqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562077; x=1785166877; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3qoMRiXvV6BHSei+lkJBYDW1cqZXXpht0BCmlOitIE4=; b=gcbAt6Pojow3TN97uAzN9ijQ2pU39T22vdymf+ge8/15Zf/tw+1NPNVcC51PkRgrCf 1h1JIhYgC062XurxNZ66EybgzGPkL+qrrkc98ZAbQO+mlXWIq0z2MBJ/od8XDiRPxE2s p8ZBsID/mf8WdK8DkKfoYq7L8w+fOHFoLLiIVCKUY97qC8AugUZtAoKGp9orJNljaoyg U97YewLeJxLImOn/nNaRfnjzHc6C8mFmNM/6y2t4pxHEQ/7GJX+k+PGwbFw2CYWcJK5N 3py1CG10nJO9BseAzim00QJBFhGilTVqY5yWyKMPVL0swmfSle0mL918uG9/fg+BV2SQ Swbw== X-Gm-Message-State: AOJu0YxL/xC+dZgD+ndccIF25Pu/KRaRdSzrJ0tCQDOEr+e9RjKGrc6z OMqWrFKfPxW5ciOe05NSdzp7vTHUp1rYwcFaog79QzHQhQZ/rrVYtkZH X-Gm-Gg: AfdE7cnuyVXMHhVE6xcWXOilMZTZrMQfDJ+WYviqLwtEO5vMBBYwACqImFjM0WOFZBN D2+Udrur4i2nOiwhr2dikV8YU0zei++T4QNGU21FKlNGPPjFBRCPrmuuZyN0tiZSIr8ye2nnVUU MjnkulUH349ONuqwkfZT3MzcyKg4CcJ8hGDpDLzXFljdBsr/OsHc+k9zeD1r1jpLZLu1iKZDZs3 Mp5Ercr0PtIBL3pvkzmLV101HRYWO8ezNt1baG1At4gmA4yoFdBtMWY0++aeum6QouEz8lIZ2Ss b3WnZODb7eVcU+g3dGvhS219cOO4c3U+aCL1JDvJyfcEnTIFJL4PDhvj0qgfVPTzPBpOuRIfJgI Aok+P8RRwXUA469InHC27JWXYsemn6/CZPIue0+h1w/eoEPBaIVIXyfvSdgRFXmD8m/4PaC6xGL K4r9kifYatng== X-Received: by 2002:a05:600c:6b69:b0:493:e583:7053 with SMTP id 5b1f17b1804b1-4954a41431cmr113435805e9.35.1784562076586; Mon, 20 Jul 2026 08:41:16 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.41.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:41:16 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:40 +0200 Subject: [PATCH v2 08/15] drm/imx: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-8-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/imx/dc/dc-kms.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/dc/dc-kms.c b/drivers/gpu/drm/imx/dc/dc-kms.c index 0f8cfaf4c4d1..a9adcfc68b84 100644 --- a/drivers/gpu/drm/imx/dc/dc-kms.c +++ b/drivers/gpu/drm/imx/dc/dc-kms.c @@ -17,7 +17,6 @@ #include #include #include -#include #include #include "dc-de.h" @@ -30,6 +29,10 @@ static const struct drm_mode_config_funcs dc_drm_mode_config_funcs = { .atomic_commit = drm_atomic_helper_commit, }; +static const struct drm_encoder_funcs dc_kms_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int dc_kms_init_encoder_per_crtc(struct dc_drm_device *dc_drm, int crtc_index) { @@ -55,7 +58,8 @@ static int dc_kms_init_encoder_per_crtc(struct dc_drm_device *dc_drm, } encoder = &dc_drm->encoder[crtc_index]; - ret = drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_NONE); + ret = drm_encoder_init(drm, encoder, &dc_kms_encoder_funcs, + DRM_MODE_ENCODER_NONE, NULL); if (ret) { dev_err(dev, "failed to initialize encoder for CRTC%u: %d\n", crtc->index, ret); -- 2.54.0