From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE4E4C4452D for ; Mon, 20 Jul 2026 15:41:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5202010E994; Mon, 20 Jul 2026 15:41:27 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="pDQLR2B4"; dkim-atps=neutral Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DED910E4A0 for ; Mon, 20 Jul 2026 15:41:22 +0000 (UTC) Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-47f785467faso723325f8f.2 for ; Mon, 20 Jul 2026 08:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784562080; x=1785166880; darn=lists.freedesktop.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=o8dh5aQckfiP03vdZ5nRuu+LA2oP+sZO4zs8QLavR/M=; b=pDQLR2B4UQ9GOb0LGLxT8KzeTJtfyfeJYiJ9DnrGAAG+fSqbsfDibk//3nX1Xih1Xh HKpLczdTzZ5Oqb1PYvr4FDCADWcFFv91Ga1zH4F9QG1sUSSORZ26NsbgpYPg4HCTg6nf Vbi+gjS7fQaDBhAFHBHo1EUDYTfGn8josFLEg0fA6PA+rCO9og4BMJ4MDNG+gsWitKDR TYr2zCejBqrUSEJ9YyzHm5J2i5nC9Rn0/4z0SzrZOQZ3fDBBcYFFJNJj05O8Ds2fH30f jDsfyQHEtYOjr7Qfq39Mi+9h5fFbJCgil3Bn0N5lp3iVfH51F6xie/G0X5c33tIkeGiS BkTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784562080; x=1785166880; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=o8dh5aQckfiP03vdZ5nRuu+LA2oP+sZO4zs8QLavR/M=; b=LUDCLS1UTP3aSJ8v0xsB2TCn5cvicqKjA586GGsrO/+yUInNxrA/6T73QnvFFxpiEa 1oLhXuYoyyD/3itlBVI4LFGIroF4+FCmp4sH5siF8o317Gs2zBgqVETEaWMOhNZjbA2a cm8etNf/GgeFmES5qi4JVgl44PzNFFWr0ewnQtOg0MP30yuhR6SiTm5HXGj3Emb5gXwk CgB44IoqW+zkXsaZ+Mrkc1esZjLlJk22/26hFNFqIBN9bqHnPFaBb4KUfTe0+sP3zi2m x9dpBmrYHgYYm3yeNvvQf2PBHo8v4wmyOzLmin4bU7aTB7kVJZGZzz0KJ0kMlpvxnbHG RqAg== X-Gm-Message-State: AOJu0YzYdGfI72bHzG7ppAP/jWYIRvGACZUFeqq/AULv3dmYfSBmX9uz JoqhHG31OOjXzsZuM4pyhI/+VIwr8PKfNtA66RM8r8bOqppYrNikhu8w X-Gm-Gg: AfdE7ck6HeLkrTqTCL6zzgejEuMQZei45Vrmhsqc5kzkArNDzL3mf2cOY9O7y9FmaoA Utp/kAYnIH0k7uEWSkD4IUIYIQ5i2WhMZsE8BpwRxRvW5xxX5YDysslnEH3NqwQpIaOKMQ7JIDj ICr7GK4gwt5oWEXNuNRYCYNDWxdkCg8c0K9VjWWXGoEt1Pr//GfM6jzyKtNUU/tI2MXFE1E2fFb W17P6IXgC/E/TT54oVFeNSm6XpHtaSDrJBPzBKCqH0VCv7OuFxSuiOQu/yEl/nXVH8N+DaWSVnS SRgfEC3nexoF4YUJrXImj7h7KhR6RmAYitDWTsgXMPLdFWScj5PtxSpiafaAbxK1gA+Yxu3m7tX Qf2LElVNF//sXVZGY7rhMimIl/nLzFS3TSv/5cuhKRcbgpppb0s/y/udInsNMvfWrIjRbmiXGuy pb/p8e/TELjw== X-Received: by 2002:a05:600c:524c:b0:495:4e12:6ae5 with SMTP id 5b1f17b1804b1-4954e126afamr155928515e9.26.1784562080376; Mon, 20 Jul 2026 08:41:20 -0700 (PDT) Received: from [127.0.0.2] ([2a01:14:111:ccf0:e9c1:2f80:10a9:c708]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47f67466e09sm32667936f8f.21.2026.07.20.08.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Jul 2026 08:41:19 -0700 (PDT) From: Diogo Silva Date: Mon, 20 Jul 2026 17:40:41 +0200 Subject: [PATCH v2 09/15] drm/mediatek: remove dependency on DRM simple helpers MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260720-drm_simple_encoder_init-v2-9-5020b630668a@gmail.com> References: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> In-Reply-To: <20260720-drm_simple_encoder_init-v2-0-5020b630668a@gmail.com> To: Jingoo Han , Inki Dae , Seung-Woo Kim , Kyungmin Park , David Airlie , Simona Vetter , Krzysztof Kozlowski , Peter Griffin , Alim Akhtar , Laurent Pinchart , Tomi Valkeinen , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Michal Simek , Thierry Reding , Mikko Perttunen , Jonathan Hunter , Stefan Agner , Alison Wang , Anitha Chrisanthus , David Airlie , Gerd Hoffmann , Dmitry Osipenko , Gurchetan Singh , Chia-I Wu , Jyri Sarha , Liu Ying , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Geert Uytterhoeven , Xinliang Liu , Sumit Semwal , Yongqin Liu , John Stultz , Liviu Dudau , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Jonathan Corbet , Shuah Khan Cc: dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, virtualization@lists.linux.dev, imx@lists.linux.dev, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-doc@vger.kernel.org, Diogo Silva X-Mailer: b4 0.15.2 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The simple KMS helpers are deprecated because they only add an intermediate layer between drivers and atomic modesetting. Open-code drm_simple_encoder_init() by calling drm_encoder_init() directly and providing driver-local drm_encoder_funcs. Signed-off-by: Diogo Silva --- drivers/gpu/drm/mediatek/mtk_dsi.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index 3f3f56eed3f9..7cd136bd9605 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -21,12 +21,12 @@ #include #include #include +#include #include #include #include #include #include -#include #include "mtk_ddp_comp.h" #include "mtk_disp_drv.h" @@ -913,12 +913,16 @@ void mtk_dsi_ddp_stop(struct device *dev) mtk_dsi_poweroff(dsi); } +static const struct drm_encoder_funcs mtk_dsi_encoder_funcs = { + .destroy = drm_encoder_cleanup, +}; + static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) { int ret; - ret = drm_simple_encoder_init(drm, &dsi->encoder, - DRM_MODE_ENCODER_DSI); + ret = drm_encoder_init(drm, &dsi->encoder, &mtk_dsi_encoder_funcs, + DRM_MODE_ENCODER_DSI, NULL); if (ret) { drm_err(drm, "Failed to encoder init to drm\n"); return ret; -- 2.54.0