Re: [PATCH 2/7] fbdev: omapfb/dsi-cm: Remove redundant dev_err()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The error paths in `dsicm_probe()` fail to unregister the DSS device, leaving it linked in the global `panel_list` while its memory is freed, leading to a critical Use-After-Free.
--

--- Patch [2]: [PATCH 2/7] fbdev: omapfb/dsi-cm: Remove redundant dev_err() ---
commit 02fb3b045764b81b12936790330528bf51db067e
Author: Pan Chuang <panchuang@vivo.com>

fbdev: omapfb/dsi-cm: Remove redundant dev_err()

This commit removes a redundant dev_err() call after devm_request_irq()
since the devm API automatically logs detailed error messages on failure.

> diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
> index 5e7963b4aa93c..7c3463ee02ef1 100644
> --- a/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
> +++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
[ ... ]
> @@ -1185,10 +1185,8 @@ static int dsicm_probe(struct platform_device *pdev)
>  				IRQF_TRIGGER_RISING,
>  				"taal vsync", ddata);
>  
> -		if (r) {
> -			dev_err(dev, "IRQ request failed\n");
> +		if (r)
>  			return r;

[Severity: High]
This is a pre-existing issue, but does returning directly here leave a
dangling pointer in the global panel_list?

Earlier in dsicm_probe(), the display is registered and added to the
global list:

	r = omapdss_register_display(dssdev);
	if (r) {
		dev_err(dev, "Failed to register panel\n");
		goto err_reg;
	}

If devm_request_irq() fails here, the function returns directly without
calling omapdss_unregister_display().

Since ddata was allocated using devm_kzalloc(), it will be automatically
freed on probe failure. Could this cause memory corruption or a
use-after-free when other functions like omap_dss_get_next_device() iterate
over the panel_list?

> -		}
>  
>  		INIT_DEFERRABLE_WORK(&ddata->te_timeout_work,
>  					dsicm_te_timeout_work_callback);

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722075803.570532-1-panchuang@vivo.com?part=2