Re: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete refactoring: nouveau driver omitted from ACPI_VIDEO and ACPI_WMI Kconfig updates.
--

--- Patch [2]: [PATCH v3 2/3] ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported() ---
commit a642691d3c901391482edfbe3099e7d703a15135
Author: Armin Wolf <W_Armin@gmx.de>

ACPI: video: Remove CONFIG_X86 handling from nvidia_wmi_ec_supported()

This commit removes the X86 architecture dependency from video-detect
and updates multiple DRM drivers to select ACPI_WMI and ACPI_VIDEO
without requiring X86. This allows the WMI-ACPI driver to support
other architectures.

[ ... ]

> diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig b/drivers/gpu/drm/amd/amdgpu/Kconfig
> index 12e4a41bf1f04..50305630f5335 100644
> --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> @@ -30,9 +30,7 @@ config DRM_AMDGPU
>  	# ACPI_VIDEO's dependencies must also be selected.
>  	select INPUT if ACPI
>  	select ACPI_VIDEO if ACPI
> -	# On x86 ACPI_VIDEO also needs ACPI_WMI
> -	select X86_PLATFORM_DEVICES if ACPI && X86
> -	select ACPI_WMI if ACPI && X86
> +	select ACPI_WMI if ACPI
>  	help
>  	  Choose this option if you have a recent AMD Radeon graphics card.

[Severity: Medium]
Should the nouveau DRM driver's Kconfig also be updated to remove the X86
dependency for these options?

While this patch successfully updates amdgpu, gma500, i915, radeon, and xe,
it appears DRM_NOUVEAU was omitted. In drivers/gpu/drm/nouveau/Kconfig, it
currently retains the architecture-specific checks:

config DRM_NOUVEAU
...
	select ACPI_WMI if ACPI && X86
...
	# Similar to i915, we need to select ACPI_VIDEO and it's dependencies
	select BACKLIGHT_CLASS_DEVICE if ACPI && X86
	select INPUT if ACPI && X86
	select THERMAL if ACPI && X86
	select ACPI_VIDEO if ACPI && X86

Does this omission mean nouveau will fail to automatically select ACPI_VIDEO
and its dependencies on non-x86 architectures, leading to a loss of
out-of-the-box ACPI backlight and WMI functionality compared to the other
DRM drivers?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724025959.142826-1-W_Armin@gmx.de?part=2