dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Sean Chang" <seanwascoding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v1 1/2] drm/ttm: drop stale @ctx kernel-doc entry
Date: Tue, 18 Aug 2026 16:13:35 +0000	[thread overview]
Message-ID: <20260818161335.A761D1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260818160914.108313-2-seanwascoding@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly claims it is fixing the documentation for `struct ttm_bo_alloc_state` rather than the function `ttm_bo_alloc_at_place()`.
--

--- Patch [1]: [PATCH v1 1/2] drm/ttm: drop stale @ctx kernel-doc entry ---
commit eda6deffe5de61d4cef4644920a61899181f3f40
Author: Sean Chang <seanwascoding@gmail.com>

drm/ttm: drop stale @ctx kernel-doc entry

This commit removes a stale @ctx kernel-doc entry in ttm_bo.c to fix a
documentation mismatch.

> ttm_bo_alloc_state no longer has a ctx member, but its kernel-doc
> comment still documents @ctx. Remove the stale entry so the
> documentation matches the struct.

[Severity: Low]
This isn't a bug, but is this description accurate?

The commit message states the documentation for struct ttm_bo_alloc_state
is being fixed, but the modified kernel-doc block actually documents the
function ttm_bo_alloc_at_place(). 

It appears the diff chunk header below mistakenly picked up the struct 
definition from earlier in the file, which may have caused the confusion.

> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index ef56c18ded1b8..943297b49dc53 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -506,7 +506,6 @@ struct ttm_bo_alloc_state {
>   *
>   * @bo: The buffer to allocate the backing store of
>   * @place: The place to attempt allocation in
> - * @ctx: ttm_operation_ctx associated with this allocation
>   * @force_space: If we should evict buffers to force space
>   * @res: On allocation success, the resulting struct ttm_resource.
>   * @alloc_state: Object holding allocation state such as charged cgroups.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260818160914.108313-1-seanwascoding@gmail.com?part=1

  reply	other threads:[~2026-08-18 16:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18 16:09 [PATCH v1 0/2] drm/ttm: two small ttm_bo.c cleanups Sean Chang
2026-08-18 16:09 ` [PATCH v1 1/2] drm/ttm: drop stale @ctx kernel-doc entry Sean Chang
2026-08-18 16:13   ` sashiko-bot [this message]
2026-08-18 16:29     ` Sean Chang
2026-08-18 16:09 ` [PATCH v1 2/2] drm/ttm: make ttm_swap_ops static Sean Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260818161335.A761D1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=seanwascoding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox