From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5C20C5DF86 for ; Wed, 19 Aug 2026 11:17:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3130910EDE8; Wed, 19 Aug 2026 11:17:06 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="PM3BM1yX"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDC0010EDE8 for ; Wed, 19 Aug 2026 11:17:04 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id A7525436D2; Wed, 19 Aug 2026 11:17:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5513A1F000E9; Wed, 19 Aug 2026 11:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787138224; bh=rpWPXVxzyxM9i3G0ilZk2iGJ3Kmn++Z5KFJ1T98nfpc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=PM3BM1yXn1CvmJ3CT/wWUQQlCx5slzKqlIOqMVRgfG0mSvV+TKMSScNRaL203EeW1 bg8n7TrXGgOiZMQcg60TTtprKD9FIW46twY+f3VG//QKsruCRNv+4T/pu1rKYu2SBO c0GBeK8dNX2e6XTSckrZ5hwrtsEcsGdTrXCKnp3276ZJgOSaZnpu2u2nXkrgUJmvxt ZjhwiKtTUkMmtZ6/ftlXlumQ0y1i9WsH1SEbsud+xgEgces4y3Fw04ZgV40cB9mPTN 5AHqs9sLPT2duwu6hCyowpOEmd89JEK1t/KiL+97B+1D9CYLC1mdruZj/91hetND2r 9/clxt+vEv0bA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 08/16] drm/tyr: specify base type for registers To: "Gary Guo" Cc: "Alexandre Courbot" , ojeda@kernel.org, dri-devel@lists.freedesktop.org, "Danilo Krummrich" , linux-pci@vger.kernel.org In-Reply-To: <20260819-typed_register-v3-8-3699a75fadf1@garyguo.net> References: <20260819-typed_register-v3-0-3699a75fadf1@garyguo.net> <20260819-typed_register-v3-8-3699a75fadf1@garyguo.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 19 Aug 2026 11:17:04 +0000 Message-Id: <20260819111704.5513A1F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Violation of vertical import style by adding a separate import stat= ement instead of grouping with existing imports. -- --- Patch [8]: [PATCH v3 08/16] drm/tyr: specify base type for registers --- commit 34aca3035b4614556abef99eebb9d34305820b18 Author: Gary Guo drm/tyr: specify base type for registers This commit specifies the base parameter for the register definitions in the drm/tyr driver. It introduces and utilizes TyrRegisters to standardize the base type across the register! macro invocations. > diff --git a/drivers/gpu/drm/tyr/regs.rs b/drivers/gpu/drm/tyr/regs.rs > index a62724378ced2..0c419c4e1186c 100644 > --- a/drivers/gpu/drm/tyr/regs.rs > +++ b/drivers/gpu/drm/tyr/regs.rs > @@ -57,7 +57,11 @@ pub(crate) mod gpu_control { > uapi, // > }; > =20 > + use crate::driver::TyrRegisters; [Severity: Low] This isn't a bug, but should this import be grouped with the existing crate::driver imports above to follow the kernel's vertical import style guidelines? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260819-typed_regi= ster-v3-0-3699a75fadf1@garyguo.net?part=3D8