From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FF5DC5DF86 for ; Wed, 19 Aug 2026 11:17:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 051FF10EDEB; Wed, 19 Aug 2026 11:17:48 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="cLRwncsn"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id C180710EDEB for ; Wed, 19 Aug 2026 11:17:46 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 450D160A58; Wed, 19 Aug 2026 11:17:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B106A1F000E9; Wed, 19 Aug 2026 11:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787138266; bh=xlnQQe6AuL5SsTfa5Tfv+DX6zxUR9nrQdQDL12txUks=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=cLRwncsngTVN59YGPu0COGKN5topBVNpetUqqgUanJ9n3kHzz9p1YPJeLR7D3FgeP lY2bD27EVilVE6/IJdeICf+HhJFI1E3Cx9JKdO1T9ztzkfZd+rjFDWNnmW5U1Gf7Om n//i2L66r2OUI06NeFNxOe6Ts5aID/tuDHkXN7zij35ofw+Fxl9pu5zUK4UGd/882g plhLImC8YV/CcZirAcDr6tjGzMwQcRX/bOKoKrTh6XteMc5iV27DPV07aIFYJsCTU+ fJHkiIsb6N4JFah9XAZu2sns4NxKSfMqP4khwWtBLkK9mVkJoEdOfqJybQ64oxMURZ LevqSwQKq8Nhg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 12/16] gpu: nova-core: use projection for PFALCON and PFALCON2 registers To: "Gary Guo" Cc: dri-devel@lists.freedesktop.org, "Danilo Krummrich" , linux-pci@vger.kernel.org, "Alexandre Courbot" , ojeda@kernel.org In-Reply-To: <20260819-typed_register-v3-12-3699a75fadf1@garyguo.net> References: <20260819-typed_register-v3-0-3699a75fadf1@garyguo.net> <20260819-typed_register-v3-12-3699a75fadf1@garyguo.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 19 Aug 2026 11:17:45 +0000 Message-Id: <20260819111745.B106A1F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Add fixed size region types `PFalconRegisters` and `PFalcon2Registers` and > update PFALCON and PFALCON2 registers to be fixed register on them and not > relative registers on `NovaRegisters`. >=20 > Update `Falcon` struct to store projected views when constructing and > access with `self.pfalcon` and `self.pfalcon2`. >=20 > Signed-off-by: Gary Guo Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260819-typed_regi= ster-v3-0-3699a75fadf1@garyguo.net?part=3D12