From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23D9BC5DF89 for ; Fri, 21 Aug 2026 14:44:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E8D9210F309; Fri, 21 Aug 2026 14:44:42 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="RgUTuzut"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9436010F2F7 for ; Fri, 21 Aug 2026 14:44:41 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4DE9442E61; Fri, 21 Aug 2026 14:44:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D9A871F000E9; Fri, 21 Aug 2026 14:44:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787323481; bh=8qPfgThyyL364l/iRyJyGOjJkKE5L9rSIGEqO7afDi8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=RgUTuzutZIRFWZo40zGEpoYmjsAZWfo2QxS9++wLKc9S8c9f6uc44egixrNkOJEjM 75kSWxtK6EOYadyM9YBs6VvUV3H2CYgdiMrfLFuYcFrCK2Uqti7uJpd7G6Q/7oRe4u DSOISBTHNEmcDgUXqHWswnfGQ0vc4RmFWQYzkvHZyQbJdaXpwJs+Mhp098gcqz61NW C3oJbFLnHRjrliNp/10TgnkTABk86XKX3udJKPm3E63mB20XtrZaxufN6Nqt7tWA9q KqPWas+4hqPgJyaQwLpgHepDs5aTJ5Tt3drt0tUs0nmbndJTaKFTnpw0AMUwI/6pXx tYf/Hirz6JZJw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/3] dt-bindings: display: add Chipwealth CH1115 OLED Controller To: =?utf-8?b?Tmljb2zDoXMgQW50aW5vcmk=?= Cc: robh@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, conor+dt@kernel.org In-Reply-To: <379eb0dbb4a911d80a3af680f647cf13ae0ece32.1787321297.git.nico.antinori.7@gmail.com> References: <379eb0dbb4a911d80a3af680f647cf13ae0ece32.1787321297.git.nico.antinori.7@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 21 Aug 2026 14:44:40 +0000 Message-Id: <20260821144440.D9A871F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The binding incorrectly uses `additionalProperties: false` alongsid= e an `allOf` `$ref` to `panel-common.yaml`, preventing the use of standard = panel properties. -- --- Patch [1]: [PATCH v2 1/3] dt-bindings: display: add Chipwealth CH1115 O= LED Controller --- commit dea96c423e55cd876a4ae165ef9b13a3b42cc6fc Author: Nicol=C3=A1s Antinori dt-bindings: display: add Chipwealth CH1115 OLED Controller Chipwealth CH1115 is a controller for monochrome dot matrix OLED panels. > diff --git a/Documentation/devicetree/bindings/display/chipwealth,ch1115.= yaml b/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml > new file mode 100644 > index 0000000000000..9d9c437221312 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/chipwealth,ch1115.yaml [ ... ] > +allOf: > + - $ref: panel/panel-common.yaml# > + > +properties: [ ... ] > + chipwealth,contrast: > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 255 > + description: > + Panel contrast. > + > + width-mm: true > + height-mm: true > + flip-horizontal: true > + flip-vertical: true > + panel-timing: true [Severity: Low] Are these manual redefinitions of standard panel properties necessary? Since they are already included via panel-common.yaml above, redefining them locally appears to be a workaround for the additionalProperties: false schema evaluation issue noted below. > + > +required: > + - compatible > + - reg > + - width-mm > + - height-mm > + - panel-timing > + > +additionalProperties: false [Severity: Low] Should this use unevaluatedProperties: false instead? Using additionalProperties: false alongside an allOf $ref restricts the schema to evaluate only locally defined properties. This causes it to incorrectly reject standard properties included from panel-common.yaml, such as backlight, power-supply, or port. Changing this to unevaluatedProperties: false allows standard panel properties to be evaluated correctly, which also removes the need to manually redefine them in this file. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1787321297.gi= t.nico.antinori.7@gmail.com?part=3D1