Re: [PATCH v2 10/12] drm/bridge: tc358767: select DRM_PANEL_BRIDGE

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete Kconfig cleanup in patch series: DRM_TOSHIBA_TC358764 uses drm_panel_bridge APIs but does not select DRM_PANEL_BRIDGE.
--

--- Patch [10]: [PATCH v2 10/12] drm/bridge: tc358767: select DRM_PANEL_BRIDGE ---
commit 0a2f8ec4febb1e1d377dd7d92fdc0b82006defba
Author: Luca Ceresoli <luca.ceresoli@bootlin.com>

drm/bridge: tc358767: select DRM_PANEL_BRIDGE

This driver uses a mixture of drm_panel and drm_panel_bridge APIs, but the
Kconfig symbol only selects DRM_PANEL. Select DRM_PANEL_BRIDGE instead,
which in turn depends on DRM_PANEL.

> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 7874d3b1e7608..8eaaa3282062a 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -399,7 +399,7 @@ config DRM_TOSHIBA_TC358767
>  	select DRM_KMS_HELPER
>  	select REGMAP_I2C
>  	select DRM_MIPI_DSI
> -	select DRM_PANEL
> +	select DRM_PANEL_BRIDGE

[Severity: Low]
Since you are updating bridge drivers in this series to select
DRM_PANEL_BRIDGE, should DRM_TOSHIBA_TC358764 also be updated?

In drivers/gpu/drm/bridge/tc358764.c:tc358764_probe(), the driver uses
devm_drm_of_get_bridge():

	ctx->next_bridge = devm_drm_of_get_bridge(dev, dev->of_node, 1, 0);
	if (IS_ERR(ctx->next_bridge))

This API call relies on CONFIG_DRM_PANEL_BRIDGE being enabled, but
config DRM_TOSHIBA_TC358764 doesn't select DRM_PANEL_BRIDGE. If the default
for CONFIG_DRM_PANEL_BRIDGE ever changes, could this cause
devm_drm_of_get_bridge() to silently return -ENODEV and fail probing?

>  	help
>  	  Toshiba TC358767 eDP bridge chip driver.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260825-drm-bridge-drm_panel-cleanup-v2-0-c6c88ba7ffd2@bootlin.com?part=10