Re: [PATCH v2 8/8] gpu: nova-core: add NVKV GSP_INIT schemas

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect vertical import alphabetical sorting for `nvkv_decode` and `nvkv_encode`.
--

commit 70350e378f301f73e838aa27ff2017d800f88a22
Author: Eliot Courtney <ecourtney@nvidia.com>

gpu: nova-core: add NVKV GSP_INIT schemas

This commit introduces the first user of NVKV encode/decode for the GSP init
request and response schemas. It implements the associated structures and
exercises them via unit tests.

> diff --git a/drivers/gpu/nova-core/gsp/fw/commands.rs b/drivers/gpu/nova-core/gsp/fw/commands.rs
> --- a/drivers/gpu/nova-core/gsp/fw/commands.rs
> +++ b/drivers/gpu/nova-core/gsp/fw/commands.rs

[ ... ]

> @@ -19,6 +21,19 @@
>      num::IntoSafeCast, //
>  };
>  
> +use crate::gsp::nvkv::{
> +    nvkv_decode,
> +    nvkv_encode,
> +    Accumulated,
> +    Array,
> +    DecoderValue,
> +    Encodable,
> +    Encoder,
> +    Key,
> +    KeyId,
> +    Required, //
> +};

[Severity: Low]
This isn't a bug, but does this import block in commands.rs miss the Rust
kernel coding guidelines for vertical import sorting?

The items nvkv_decode and nvkv_encode are placed at the top of the list, but
alphabetically they should come after the capitalized items like Accumulated,
Array, and DecoderValue. Should these be relocated to their proper
alphabetical position at the bottom of this import block?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260827-b4-nvkv-v2-0-0de9d5c8658c@nvidia.com?part=8