dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: anshika <anshikajain196872@gmail.com>
Cc: Andy Shevchenko <andy@kernel.org>,
	Dan Carpenter <error27@gmail.com>,
	dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: fbtft: name the no-op endian modifier in define_fbtft_write_reg()
Date: Mon, 31 Aug 2026 07:47:02 +0200	[thread overview]
Message-ID: <2026083121-suspend-constable-9e1a@gregkh> (raw)
In-Reply-To: <20260830161529.14500-1-anshikajain196872@gmail.com>

On Sun, Aug 30, 2026 at 09:45:29PM +0530, anshika wrote:
> Two of the three define_fbtft_write_reg() instantiations pass an empty
> modifier argument, which checkpatch flags as a fragile empty macro
> argument. Give the no-op case an explicit name instead of leaving it
> blank.

Checkpatch is wrong.

> No functional change.
> 
> Link: https://lkml.iu.edu/hypermail/linux/kernel/2602.0/01917.html
> 
> Signed-off-by: anshika <anshikajain196872@gmail.com>

We would need a full name anyway.

Just leave this as-is please, it's fine.

thanks,

greg k-h

  reply	other threads:[~2026-08-31  5:48 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-30 16:15 [PATCH] staging: fbtft: name the no-op endian modifier in define_fbtft_write_reg() anshika
2026-08-31  5:47 ` Greg Kroah-Hartman [this message]
2026-08-31  7:07 ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026083121-suspend-constable-9e1a@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andy@kernel.org \
    --cc=anshikajain196872@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=error27@gmail.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox