Re: [PATCH v7 10/12] drm/xe: Indicate support for luminance on the connector

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit silently introduces and enables a new, undocumented DRM feature flag (DRIVER_GEM_GPUVA), which is completely unrelated to connector luminance.
--

commit 2a9c8dfbbc421c84ac6987dc02eb16939b1f82f5
Author: Mario Limonciello <mario.limonciello@amd.com>

drm/xe: Indicate support for luminance on the connector

This commit enables the connector to show luminance information for eDP panels 
in the xe driver by setting the DRIVER_CONNECTOR_LUMINANCE driver feature.

> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
> index f9791c850e520..b65bbe8fde0c3 100644
> --- a/drivers/gpu/drm/xe/xe_device.c
> +++ b/drivers/gpu/drm/xe/xe_device.c
> @@ -397,7 +397,8 @@ static const struct drm_driver regular_driver = {
>  	    XE_DISPLAY_DRIVER_FEATURES |
>  	    DRIVER_GEM |
>  	    DRIVER_RENDER | DRIVER_SYNCOBJ |
> -	    DRIVER_SYNCOBJ_TIMELINE,
> +	    DRIVER_CONNECTOR_LUMINANCE |
> +	    DRIVER_SYNCOBJ_TIMELINE | DRIVER_GEM_GPUVA,

[Severity: Medium]
Does this code intentionally enable DRIVER_GEM_GPUVA for the xe driver
in this patch? 

The commit message only mentions adding support for luminance on the
connector, which suggests this flag might have been accidentally squashed
into this patch.

>  	.open = xe_file_open,
>  	.postclose = xe_file_close,
>  
> diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
> index 449160b9863f6..bda0f0bd7b16b 100644
> --- a/include/drm/drm_drv.h
> +++ b/include/drm/drm_drv.h
> @@ -125,6 +125,13 @@ enum drm_driver_feature {
>  	 */
>  	DRIVER_CONNECTOR_LUMINANCE           = BIT(10),
>  
> +	/**
> +	 * @DRIVER_GEM_GPUVA:
> +	 *
> +	 * Driver supports GEM GPU virtual addressing.
> +	 */
> +	DRIVER_GEM_GPUVA               = BIT(11),
> +

[Severity: Medium]
Is the DRIVER_GEM_GPUVA flag definition meant to be included here? 

It appears unrelated to the connector luminance changes described in the
commit message and might belong in a separate, dedicated patch.

>  	/* IMPORTANT: Below are all the legacy flags, add new ones above. */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260831210531.2334221-1-mario.limonciello@amd.com?part=10