From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78BB3C624D3 for ; Tue, 1 Sep 2026 16:56:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BDE6689131; Tue, 1 Sep 2026 16:56:46 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="BwP9zK2D"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 009D410E5A8 for ; Tue, 1 Sep 2026 16:56:44 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 78EA56020D; Tue, 1 Sep 2026 16:56:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF70F1F000E9; Tue, 1 Sep 2026 16:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788281804; bh=GHzELN0xThaJnvdVdCzOhVkGCHy37qdXcSez0RKtoK4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=BwP9zK2Dp+GB+ZM7kGVF3Okbs/H87GrhnSrtEk0Z8Urex4MPcx3cYCmwH/Pbm15R6 m0YznQZWrDFiaVYRoewPyjA22ronvlte1EDJaq3t36Hwtu9tb6sHbjFZgEMrGGuSfw aKkFG7v5PqXcKseWX9MnulqFdom3OU7PY3osa1AQaoUI0XpKAMN7GLzEvh3hee9PZA 4l+2UgUmrDtm3PTAzR1fwdEwHMzp104i2YvKXFwoPJkEZJRgwFa5+mBe2GM2mzIXYg hmL1bzXa5qD+OCnoYjPJIpV0bqMC6zn1F0kzVOAdtv6s2WchPXFiB/z+XAC0rSYdPk 2z5FlF0mpZi6Q== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 09/16] samples: rust: pci: specify base type for registers To: "Gary Guo" Cc: dri-devel@lists.freedesktop.org, "Danilo Krummrich" , ojeda@kernel.org, linux-pci@vger.kernel.org, "Alexandre Courbot" In-Reply-To: <20260901-typed_register-v4-9-5552b1d59525@garyguo.net> References: <20260901-typed_register-v4-0-5552b1d59525@garyguo.net> <20260901-typed_register-v4-9-5552b1d59525@garyguo.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 01 Sep 2026 16:56:43 +0000 Message-Id: <20260901165643.DF70F1F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > The `register!` macro is going to require explicit base type, specify it > for both `register!` usages in PCI sample driver. >=20 > Reviewed-by: Alexandre Courbot > Signed-off-by: Gary Guo Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260901-typed_regi= ster-v4-0-5552b1d59525@garyguo.net?part=3D9