From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CAB9C624D3 for ; Tue, 1 Sep 2026 17:02:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B492010EDE6; Tue, 1 Sep 2026 17:02:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="LCYKiTRn"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 217EB10EDE6 for ; Tue, 1 Sep 2026 17:02:28 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0AA25437E4; Tue, 1 Sep 2026 17:02:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FFEF1F00A3A; Tue, 1 Sep 2026 17:02:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788282147; bh=7OyxcXjNio9xfsFpxDUvQBwVaapGhBg6JSqt4WDNPLo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=LCYKiTRnDxleectKjtpciXToeKNpvOvr7roBkvfndqnOcRrHo2sM4UlrFPuIy+2id SD6SKcBC3Vr4IcglYP3zEjHdpDBNu7JUNrbdGlLSIp4jPHwIEioEOpfr/EkaNHlJhs EempGxieab7uUWiU3P54l0Is49jtTs/mKLdvKSweHHVVeIZAxe/cA/CUDPRGoYSZne vLFjAg2CGRx3+BJmYU0is+SxFx4iM8n6gcQ2heBndUgU+ZZKnX2gvAn6v8lZpowqY5 XgZbbayCaHTLphloE0pZj42u5Ub5YLCnOjO5G+O5M/qbsuPs5FDq1CwnEycP4wR1Au tlOhbVmS1SqWg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 14/16] rust: io: register: remove relative registers To: "Gary Guo" Cc: "Alexandre Courbot" , linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org, "Danilo Krummrich" , ojeda@kernel.org In-Reply-To: <20260901-typed_register-v4-14-5552b1d59525@garyguo.net> References: <20260901-typed_register-v4-0-5552b1d59525@garyguo.net> <20260901-typed_register-v4-14-5552b1d59525@garyguo.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 01 Sep 2026 17:02:27 +0000 Message-Id: <20260901170227.8FFEF1F00A3A@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Relative registers can be better served by projection to subregion instead > of ad-hoc handling in register macro. Projection composes better (e.g. it > natively allows relative registers of relative registers without needing > additional support). >=20 > Remove relative register support, and update the documentation to > demonstrate how projection and subregions can be used to achieve this > instead. >=20 > Reviewed-by: Alexandre Courbot > Signed-off-by: Gary Guo Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260901-typed_regi= ster-v4-0-5552b1d59525@garyguo.net?part=3D14