From: Lyude Paul <lyude@redhat.com>
To: dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev,
linux-kernel@lists.freedesktop.org
Cc: Christian Hergert <christian@sourceandstack.com>,
"Dmitry Osipenko" <dmitry.osipenko@collabora.com>,
"David Airlie" <airlied@redhat.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
linux-kernel@vger.kernel.org, "Simona Vetter" <simona@ffwll.ch>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Maxime Ripard" <mripard@kernel.org>,
"Lyude Paul" <lyude@redhat.com>
Subject: [PATCH 2/2] drm/virtio: Recalculate ignore_damage_clips on every update
Date: Thu, 3 Sep 2026 17:15:52 -0400 [thread overview]
Message-ID: <20260903211914.1109100-3-lyude@redhat.com> (raw)
In-Reply-To: <20260903211914.1109100-1-lyude@redhat.com>
From: Christian Hergert <christian@sourceandstack.com>
Plane state duplication preserves ignore_damage_clips. Once fbdev sets
it for a dumb buffer, later updates using rendered resources continue to
ignore damage because the flag is never cleared.
Assign ignore_damage_clips on every atomic check so rendered resources
can use supplied damage after an earlier dumb-buffer update.
Signed-off-by: Christian Hergert <christian@sourceandstack.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/virtio/virtgpu_plane.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c
index d9579a4b4714c..95ec688690d3a 100644
--- a/drivers/gpu/drm/virtio/virtgpu_plane.c
+++ b/drivers/gpu/drm/virtio/virtgpu_plane.c
@@ -119,8 +119,8 @@ static int virtio_gpu_plane_atomic_check(struct drm_plane *plane,
* so preserve userspace's accumulated per-buffer damage for those.
*/
bo = gem_to_virtio_gpu_obj(new_plane_state->fb->obj[0]);
- if (old_plane_state->fb != new_plane_state->fb && bo->dumb)
- new_plane_state->ignore_damage_clips = true;
+ new_plane_state->ignore_damage_clips =
+ old_plane_state->fb != new_plane_state->fb && bo->dumb;
crtc_state = drm_atomic_get_crtc_state(state,
new_plane_state->crtc);
--
2.55.0
next prev parent reply other threads:[~2026-09-03 21:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 21:15 [PATCH 0/2] drm/virtio: Damage clip fixes Lyude Paul
2026-09-03 21:15 ` [PATCH 1/2] drm/virtio: preserve damage clips for rendered resources Lyude Paul
2026-09-03 21:15 ` Lyude Paul [this message]
2026-09-03 21:27 ` [PATCH 2/2] drm/virtio: Recalculate ignore_damage_clips on every update sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260903211914.1109100-3-lyude@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@redhat.com \
--cc=christian@sourceandstack.com \
--cc=dmitry.osipenko@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox