dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Hemanth Selam" <hemanth.selam@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/3] drm: fix repeated words in comments
Date: Fri, 04 Sep 2026 12:09:45 +0000	[thread overview]
Message-ID: <20260904120945.807571F00A3E@smtp.kernel.org> (raw)
In-Reply-To: <20260904120430.17224-3-hemanth.selam@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incorrect grammar correction altering comment meaning.
--

commit a1ccb2e6474d515b1b000ccef6e3cfcb3d32f358
Author: Hemanth Selam <hemanth.selam@gmail.com>

drm: fix repeated words in comments

This commit addresses warnings from checkpatch.pl by dropping words that appear
to be accidentally repeated in comments. The changes are intended to only touch
comments without affecting code execution.

> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> index 6dfb45592d747..be3c3c074e75d 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
[ ... ]
> @@ -339,7 +339,7 @@ static int vmw_execbuf_res_val_add(struct vmw_sw_context *sw_context,
>  }
>  
>  /**
> - * vmw_view_res_val_add - Add a view and the surface it's pointing to to the
> + * vmw_view_res_val_add - Add a view and the surface it's pointing to the
>   * validation list
>   *

[Severity: Low]
Does this grammar correction alter the intended meaning of the comment?

The original phrase in vmw_view_res_val_add() uses the first "to" as part of
"pointing to", and the second "to" as part of "to the validation list".
By removing one, the sentence now implies the surface is pointing to the
validation list, rather than adding the surface to the validation list.

>   * @sw_context: The software context holding the validation list.
[ ... ]
> @@ -367,7 +367,7 @@ static int vmw_view_res_val_add(struct vmw_sw_context *sw_context,
>  
>  /**
>   * vmw_view_id_val_add - Look up a view and add it and the surface it's pointing
> - * to to the validation list.
> + * to the validation list.
>   *
>   * @sw_context: The software context holding the validation list.

[Severity: Low]
Does this change have the same issue as above?

It changes the sentence structure in vmw_view_id_val_add() such that it no
longer means adding the surface (that the view points to) to the validation
list.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260904120430.17224-1-hemanth.selam@gmail.com?part=2

  reply	other threads:[~2026-09-04 12:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260904120430.17224-1-hemanth.selam@gmail.com>
2026-09-04 12:04 ` [PATCH 1/3] drm: fix typos in comments Hemanth Selam
2026-09-04 12:13   ` Philipp Stanner
2026-09-04 12:34     ` Tomi Valkeinen
2026-09-04 13:19       ` Luca Ceresoli
2026-09-04 12:32   ` Natalie Vock
2026-09-04 12:04 ` [PATCH 2/3] drm: fix repeated words " Hemanth Selam
2026-09-04 12:09   ` sashiko-bot [this message]
2026-09-04 12:04 ` [PATCH 3/3] drm/vmwgfx: fix repeated word in log message Hemanth Selam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260904120945.807571F00A3E@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hemanth.selam@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox