From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1ED09C79F82 for ; Tue, 8 Sep 2026 20:38:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54BD210ED79; Tue, 8 Sep 2026 20:38:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="eE9GmdLD"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id A83B410ED79 for ; Tue, 8 Sep 2026 20:38:00 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 721274367B; Tue, 8 Sep 2026 20:38:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7AD691F00A3A; Tue, 8 Sep 2026 20:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788899880; bh=F7DmoYHsBg14zxdNM6f82a6mXZ80MX2i1zvDc4vpwg0=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=eE9GmdLDwKtb/fVSpKHf42maGv86xcNqPguLsD4Ja85IBBHdNRQWyDBDp4krhIxaT IUmNEIDghowO1nMJoInHcn7Ki2FoWqmrVSkY/tuneHPeBePBlny4eRLjcpRGqY9faj +0/0QD8toMXpPD6H3WEBSPw8qU3Frua+06CoCN+OpGLKxEZTo16QtWaVqTfdRwR6vb gwm2r+oQ3s5UK776IO/DofRpLAo9AVk529/oPLbQliUwZZ2dSG09vofCJOTnOtCFhB B6fGn+474oNFE+wPzNGiwNsIrTHk4RNxpE9ED6Kt1Z4L2Bt6zITRfb51XWPAHNprvP mmQ+xfbg3qetg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 17/39] scsi: sg: convert mmap hook to mmap_prepare and rework To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: dri-devel@lists.freedesktop.org, "Christian Borntraeger" , "Marc Zyngier" , "Vasily Gorbik" , linux-scsi@vger.kernel.org, "Oliver Upton" , kvm@vger.kernel.org, selinux@vger.kernel.org, "Alexander Gordeev" , "Heiko Carstens" , kvmarm@lists.linux.dev, linux-s390@vger.kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org In-Reply-To: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-17-dacf19cce22b@kernel.org> References: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org> <20260908-b4-mmap-prepare-vma-flag-sanify-v1-17-dacf19cce22b@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 08 Sep 2026 20:37:58 +0000 Message-Id: <20260908203759.7AD691F00A3A@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Move from the deprecated mmap hook to the new mmap_prepare hook. >=20 > We are mapping kernel pages here, so use the discontiguous kernel mapping > mmap action to do so. >=20 > Unwind the rather confusing loop and instead map as many pages as we can = at > one time. >=20 > Note that we do not need to pay attention to rsv_schp->k_use_sg here, as > the pages are populated for the length of the buffer at > rsv_schp->page_order granularity as compound pages. >=20 > The discontiguous kernel page mapping logic handles the compound pages for > us. >=20 > sfp->mmap_called keeps the buffer stable for us. As before it is never > cleared, so a failed mmap also leaves it set. >=20 > We also remove some useless vma, vma->vm_file NULL checks - these will > always be non-NULL if you reached the mmap hook logic. >=20 > We retain log output for consistency, but change what's output on page > mapping to indicate that sg_discontig_get() does the work now. >=20 > Note that we drop the VMA_IO_BIT flag for the VMA here. It was never > necessary as we invoke alloc_pages() which gives us refcounted folios that > are fine for GUP to access (VMA_IO_BIT would prevent that). >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260908-b4-mmap-pr= epare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org?part=3D17