From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47C5CC79F82 for ; Tue, 8 Sep 2026 20:38:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7151110ED7C; Tue, 8 Sep 2026 20:38:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="f7diApag"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id B089E10ED7C for ; Tue, 8 Sep 2026 20:38:22 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id EEA7C601DE; Tue, 8 Sep 2026 20:38:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E26131F00A3A; Tue, 8 Sep 2026 20:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788899901; bh=3FmB7rMB7W+zd8I+08aizQ0FJkQHIiLBhCXPX9ap9Y8=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=f7diApagFqZbGgd6pH4K5iirRLD9yF5/ODra3BSWwjisqk+0LaNnrOhY96eJBIOmf kmFrgdpkYzPOEqor4yWsue5/SSjw1lw18m2DKJtptnVnYdGsbk7Wu6vMrUlynT8UgD bvVWW8AHIyHrnqHmoFkaBxH0t5soTPx2W+eSwYhKvE4PwFp/PMm7rfnAIAyb6atvy9 5ot18378dDl58bAVyv4y7sQepP1swB7lm+k83bE+YNvFu+v1TyiNs3BkH7wOESfGyR wEhjKXOaLkwRNyyCm/q4AUszA6ek0xbr4I68hIGm2X9Wu9BJy/nDECGvcLEQmuwwdO knBMvSPprIGMw== From: sashiko-bot@kernel.org Subject: Re: [PATCH 22/39] mm/mlock: clear VMA_LOCKED_MASK over mmap callback To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: linux-perf-users@vger.kernel.org, "Oliver Upton" , kvm@vger.kernel.org, "Alexander Gordeev" , selinux@vger.kernel.org, kvmarm@lists.linux.dev, dri-devel@lists.freedesktop.org, "Christian Borntraeger" , bpf@vger.kernel.org, "Vasily Gorbik" , linux-scsi@vger.kernel.org, "Marc Zyngier" , linux-trace-kernel@vger.kernel.org, "Heiko Carstens" , linux-s390@vger.kernel.org In-Reply-To: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-22-dacf19cce22b@kernel.org> References: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org> <20260908-b4-mmap-prepare-vma-flag-sanify-v1-22-dacf19cce22b@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 08 Sep 2026 20:38:20 +0000 Message-Id: <20260908203820.E26131F00A3A@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Currently there's a confusing mess around VMA_LOCKED_BIT and > VMA_LOCKONFAULT_BIT. >=20 > It is permitted for drivers to set any flags they like, with the VMA > already possessing lock flags. >=20 > This results in the absurd situation of a VMA possessing both > VMA_SPECIAL_FLAGS and VMA_LOCKED_MASK flags, which is not permitted. >=20 > This has resulted in mlock_vma_folio() having a very silly check for this > scenario to work around it. >=20 > There is no need for this - just clear the flags before invoking the hook > and reinstate them afterwards if they are required. >=20 > Nothing relies upon this being set during the mmap operation. >=20 > mmap_prepare is unaffected by this so requires no fix. >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260908-b4-mmap-pr= epare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org?part=3D22