From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DDCBC79F82 for ; Tue, 8 Sep 2026 20:40:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 897E510ED81; Tue, 8 Sep 2026 20:40:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="GW6lmw0P"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 170D910ED81 for ; Tue, 8 Sep 2026 20:40:24 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 8EF96601DE; Tue, 8 Sep 2026 20:40:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 76A2A1F00A3A; Tue, 8 Sep 2026 20:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788900023; bh=NfxFEqWgzsyysgen68P0bT+LbvYNMhsQXQuYa/vQPVY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=GW6lmw0P3OMZhlc8JcIgfSAwLKcsv0dhgMYQjB0UkBG5zLccK7KZf2vwriCI77e/g dP70BhWNJpeJ2Ld4RGVE6rEL4o/1UOFIyonSTb/+Zzo2YIz22Q22tP/DlTtIrB/u9I ctCkvLlbAolPJ4wKMOk4UKj1ql6gO3F6abhID0H7z+rhQ1wECStOwu8TMZ6/zQQcmE EyWef/lbJwYWK1AjM/rYf0SnL38+yHlaYMnh1r7rMPQA1bx4hsKy61XL8MGX+X8GEZ ozipCaroIWT9XyvcaIMMh3h6DPcHNeo34XyOls3its5DnEuLeNeY3p0HDVeyAhoaAZ pJHpPCb0Kxt4w== From: sashiko-bot@kernel.org Subject: Re: [PATCH 27/39] mm: rename is_vm_hugetlb_page() to vma_is_hugetlb() To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: bpf@vger.kernel.org, "Heiko Carstens" , linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, kvm@vger.kernel.org, "Marc Zyngier" , linux-s390@vger.kernel.org, "Christian Borntraeger" , "Vasily Gorbik" , dri-devel@lists.freedesktop.org, selinux@vger.kernel.org, "Oliver Upton" , kvmarm@lists.linux.dev, "Alexander Gordeev" , linux-scsi@vger.kernel.org In-Reply-To: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-27-dacf19cce22b@kernel.org> References: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org> <20260908-b4-mmap-prepare-vma-flag-sanify-v1-27-dacf19cce22b@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 08 Sep 2026 20:40:22 +0000 Message-Id: <20260908204022.76A2A1F00A3A@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > The is_vm_hugetlb_page() predicate is badly named - the mapping can span > more than a page and it is inconsistent with other VMA predicates that > typically are prefixed by vma_. >=20 > Rename to vma_is_hugetlb() for consistency, and while we're here update > some VM_BUG_ON_VMA() to VM_WARN_ON_ONCE_VMA() as to avoid unnecessary > oopses. >=20 > No functional change intended. >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260908-b4-mmap-pr= epare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org?part=3D27