From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71D12C79F99 for ; Tue, 8 Sep 2026 20:45:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7A65C10ED8A; Tue, 8 Sep 2026 20:45:16 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="UQN30dWJ"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BE8510ED8A for ; Tue, 8 Sep 2026 20:45:12 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 92C84601F7; Tue, 8 Sep 2026 20:45:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 831161F00A3D; Tue, 8 Sep 2026 20:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788900311; bh=lfX1XLXDKjaQ1hZ7XBgaLjSBi6sT1IIdcg4WNB0jRhI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UQN30dWJwpo4V26dZC3AaUHsG2hOS/xHT3lNBlbcetD/oJNqKXV4MoEcunr7NwsWK renQVIHz5ptMXhKDVsYTwLLVuO5HvVauR2+LJz4YvqrcUJgJzFPkbq+sTWU5Dx5Njc 3CAW+UVWWmi1GFMyQm45EB8Jtkf6hvacLvI/l/Xoo/u/HCOeN6lvJS5IyABEVJ6vSR kQpBNg5GO8Vy5ywxwIPiwjoI6QuiA9SHiMCcSEjiO0AEJQ3fxMaOf/a2FBjluod/Qy Jb+GwVWvtPtT6rnk10lA3DS6hu0he65vbiCM4qqqSzYT48HwO6Ywg9IYMSRFEVwfkh CQNAq5+G5+y5g== From: sashiko-bot@kernel.org Subject: Re: [PATCH 34/39] mm: eliminate VMA_SPECIAL_FLAGS check in lru_gen_look_around() To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: kvmarm@lists.linux.dev, linux-s390@vger.kernel.org, "Oliver Upton" , bpf@vger.kernel.org, linux-scsi@vger.kernel.org, "Heiko Carstens" , "Christian Borntraeger" , linux-perf-users@vger.kernel.org, linux-trace-kernel@vger.kernel.org, selinux@vger.kernel.org, "Vasily Gorbik" , "Marc Zyngier" , "Alexander Gordeev" , kvm@vger.kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-34-dacf19cce22b@kernel.org> References: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org> <20260908-b4-mmap-prepare-vma-flag-sanify-v1-34-dacf19cce22b@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 08 Sep 2026 20:45:10 +0000 Message-Id: <20260908204510.831161F00A3D@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > A kernel-owned or fixed mapping is one which sets VMA_PFNMAP_BIT, > VMA_MIXEDMAP_BIT or VMA_DONTEXPAND_BIT, which is precisely what > VMA_SPECIAL_FLAGS tests for other than VMA_IO_BIT, which is safe to drop = as > only kernel-owned mappings may set it. >=20 > Using these predicates rather than VMA_SPECIAL_FLAGS makes the check > self-documenting and helps eliminate the confusion around 'special' flags. >=20 > No functional change intended. >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260908-b4-mmap-pr= epare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org?part=3D34