From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 72D36C79F82 for ; Tue, 8 Sep 2026 20:45:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9ECAE10ED90; Tue, 8 Sep 2026 20:45:38 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="UrgLIS59"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 67F1F10ED90 for ; Tue, 8 Sep 2026 20:45:35 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id AD4B7601F7; Tue, 8 Sep 2026 20:45:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9CAC21F00A3D; Tue, 8 Sep 2026 20:45:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1788900334; bh=JHusAbsM1Jq/q2msxxZARsh1g6aTv3BLE2tFclqVzns=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=UrgLIS59Kt8qQ3K4lOfJeTqo/Whczszd23C0+SmmVjE70kdrQVe/V9MLu3q8mp6a3 xeG3Epr9aKdq2rsH2sJ2sRiasnWUXwI7I0IoUdZycWYg1ld0WOhGBBN6ecVd6WkHST PUpdq29RBY6MvIg9++ZLfGGOLz/cQLyrgyTqmghAWJQa2EjbG7gIRVyxp18qHnqt0M WiMddCvVUJBc2ensJA3/nbdZ6ErAuuefoHuIEsrPY054ZAt50qKzO2otHaBKv+hQEc ioPKPel60iCIpv+oOV4WQrfwiat6fzYNYCbgEA5V53laTZXBgkE51EhaQR5qs65jNx TRW2JlJspbNMA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 31/39] mm/uffd: use predicates for userfaultfd checks To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: linux-trace-kernel@vger.kernel.org, "Heiko Carstens" , selinux@vger.kernel.org, "Alexander Gordeev" , "Christian Borntraeger" , dri-devel@lists.freedesktop.org, bpf@vger.kernel.org, "Vasily Gorbik" , linux-perf-users@vger.kernel.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, "Oliver Upton" , linux-scsi@vger.kernel.org, "Marc Zyngier" , linux-s390@vger.kernel.org In-Reply-To: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-31-dacf19cce22b@kernel.org> References: <20260908-b4-mmap-prepare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org> <20260908-b4-mmap-prepare-vma-flag-sanify-v1-31-dacf19cce22b@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 08 Sep 2026 20:45:33 +0000 Message-Id: <20260908204533.9CAC21F00A3D@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Rather than directly checking VMA flags, use the newly introduced > vma_is_kernel_owned() and vma_is_persistent() helpers in userfaultfd when > assessing VMA suitability for userfaultfd and UFFDIO_MOVE. >=20 > Update vma_move_compatible() so it's expressed in terms of VMA > characteristics rather than arbitrary flags. >=20 > Additionally, update the use of the deprecated VMA flag API when checking > VMA_SHADOW_STACK_BIT. >=20 > A VMA_IO_BIT check is no longer required but that is fine as a hard > invariant has been established that only kernel-owned mappings may set > VMA_IO_BIT so the check is now redundant. >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260908-b4-mmap-pr= epare-vma-flag-sanify-v1-0-dacf19cce22b@kernel.org?part=3D31