From: sashiko-bot@kernel.org
To: "Thomas Zimmermann" <tzimmermann@suse.de>
Cc: virtualization@lists.linux.dev, intel-xe@lists.freedesktop.org,
imx@lists.linux.dev, gary@garyguo.net,
"Michael S. Tsirkin" <mst@redhat.com>,
wsa+renesas@sang-engineering.com,
intel-gfx@lists.freedesktop.org, ojeda@kernel.org,
Frank.Li@kernel.org, linux-hyperv@vger.kernel.org,
dri-devel@lists.freedesktop.org,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v4 13/14] drm/panic: Move panic display code into helper library
Date: Wed, 09 Sep 2026 09:32:44 +0000 [thread overview]
Message-ID: <20260909093244.E02581F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260909085826.64529-14-tzimmermann@suse.de>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] CONFIG_DRM_PANIC_SCREEN_QR_CODE can be enabled without its source code being compiled.
--
commit cfc7923d9a3badf08604fdffe1b2f5534bf2b0b6
Author: Thomas Zimmermann <tzimmermann@suse.de>
drm/panic: Move panic display code into helper library
This commit moves the panic display code and drm_plane_helper_display_panic_screen()
into a new drm_panic_helper.c library. It renames symbols and updates the QR-related
code accordingly, linking the object files into the drm_kms_helper module.
> diff --git a/drivers/gpu/drm/Makefile b/drivers/gpu/drm/Makefile
> index e635fcffd3790..f0c340aa2ec60 100644
> --- a/drivers/gpu/drm/Makefile
> +++ b/drivers/gpu/drm/Makefile
[ ... ]
> @@ -157,6 +156,8 @@ drm_kms_helper-y := \
> drm_simple_kms_helper.o \
> drm_vblank_helper.o
> drm_kms_helper-$(CONFIG_DRM_PANEL_BRIDGE) += bridge/panel.o
> +drm_kms_helper-$(CONFIG_DRM_PANIC_HELPER) += drm_panic_helper.o
> +drm_kms_helper-$(CONFIG_DRM_PANIC_SCREEN_QR_CODE) += drm_panic_helper_qr.o
[Severity: Low]
Does this allow CONFIG_DRM_PANIC_SCREEN_QR_CODE to be enabled without its
source code being compiled?
Since drm_panic_helper_qr.o is now built into drm_kms_helper, if a kernel is
configured with CONFIG_DRM_KMS_HELPER=n and CONFIG_DRM_PANIC_SCREEN_QR_CODE=y,
the QR code source (drm_panic_helper_qr.rs) will be silently omitted from the
build. The definition for CONFIG_DRM_PANIC_SCREEN_QR_CODE in
drivers/gpu/drm/Kconfig currently does not depend on or select DRM_KMS_HELPER.
Should the Kconfig dependencies be updated to prevent this configuration
mismatch?
[ ... ]
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909085826.64529-1-tzimmermann@suse.de?part=13
next prev parent reply other threads:[~2026-09-09 9:32 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 8:55 [PATCH v4 00/14] drm/panic: Split into core and helpers Thomas Zimmermann
2026-09-09 8:55 ` [PATCH v4 01/14] drm/panic: Do not use un-escaped URL as format string Thomas Zimmermann
2026-09-09 9:09 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 02/14] drm/panic: Test address from kmap op for NULL Thomas Zimmermann
2026-09-09 9:15 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 03/14] drm/panic: Return -EINVAL if font is not available Thomas Zimmermann
2026-09-09 9:08 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 04/14] drm/panic: Return errno codes if panic output fails Thomas Zimmermann
2026-09-09 9:13 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 05/14] drm/panic: Pass colors to draw_panic_dispatch() Thomas Zimmermann
2026-09-09 9:13 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 06/14] drm/panic: Pass global module parameters to drm_panic_dispatch() Thomas Zimmermann
2026-09-09 9:22 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 07/14] drm/panic: Return from screen_user if display is too small Thomas Zimmermann
2026-09-09 9:18 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 08/14] drm/panic: Retry in dispatch function if panic output fails Thomas Zimmermann
2026-09-09 9:17 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 09/14] drm/panic: Split draw_panic_plane() Thomas Zimmermann
2026-09-09 9:20 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 10/14] drm/panic: Restrict to primary planes Thomas Zimmermann
2026-09-09 9:22 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 11/14] drm/panic: Display panic screen via per-plane callback Thomas Zimmermann
2026-09-09 9:29 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 12/14] drm/panic: Internalize panic locking in DRM core and helpers Thomas Zimmermann
2026-09-09 9:28 ` sashiko-bot
2026-09-09 8:55 ` [PATCH v4 13/14] drm/panic: Move panic display code into helper library Thomas Zimmermann
2026-09-09 9:32 ` sashiko-bot [this message]
2026-09-09 8:55 ` [PATCH v4 14/14] drm/panic: Compile KUnit tests as module Thomas Zimmermann
2026-09-09 9:37 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909093244.E02581F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=gary@garyguo.net \
--cc=imx@lists.linux.dev \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=mst@redhat.com \
--cc=ojeda@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox