From: sashiko-bot@kernel.org
To: "Arnd Bergmann" <arnd@kernel.org>
Cc: conor+dt@kernel.org, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
mfd@lists.linux.dev, linux-hwmon@vger.kernel.org, lee@kernel.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-watchdog@vger.kernel.org, media-ci@linuxtv.org,
linux-rtc@vger.kernel.org, linux-leds@vger.kernel.org,
robh@kernel.org
Subject: Re: [PATCH 09/14] mfd: remove unused lm3533 driver
Date: Wed, 09 Sep 2026 13:35:10 +0000 [thread overview]
Message-ID: <20260909133510.E67B61F00A3D@smtp.kernel.org> (raw)
In-Reply-To: <20260909132153.1596191-10-arnd@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Leftover sysfs ABI documentation files for the removed LM3533 driver.
--
commit dd454943eacd9b46650ee0d6e1e22a90fadba749
Author: Arnd Bergmann <arnd@arndb.de>
mfd: remove unused lm3533 driver
This commit removes the lm3533 driver, including the MFD core, LED, ALS,
and backlight components, as it has never had any users and lacks devicetree
support.
> mfd: remove unused lm3533 driver
>
> This driver has apparently never had any users, as it does not support
> devicetree probing, and no lm3533_platform_data definition ever
> existed upstream.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[Severity: Low]
Does this commit leave orphaned sysfs ABI documentation behind? The patch
removes the driver source files but it looks like the associated ABI
documentation files were left in the tree:
- Documentation/ABI/testing/sysfs-bus-i2c-devices-lm3533
- Documentation/ABI/testing/sysfs-bus-iio-light-lm3533-als
- Documentation/ABI/testing/sysfs-class-backlight-driver-lm3533
- Documentation/ABI/testing/sysfs-class-led-driver-lm3533
Should these documentation files be removed along with the source files?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260909132153.1596191-1-arnd@kernel.org?part=9
next prev parent reply other threads:[~2026-09-09 13:35 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 13:21 [PATCH 00/14] mfd: unused driver purge Arnd Bergmann
2026-09-09 13:21 ` [PATCH 01/14] mfd: remove unused 88pm80x driver Arnd Bergmann
2026-09-09 13:37 ` sashiko-bot
2026-09-09 13:44 ` Alexandre Belloni
2026-09-11 7:24 ` Krzysztof Kozlowski
2026-09-09 13:21 ` [PATCH 02/14] mfd: remove unused rdc321x southbridge support Arnd Bergmann
2026-09-09 13:39 ` sashiko-bot
2026-09-09 20:28 ` Arnd Bergmann
2026-09-09 14:09 ` Guenter Roeck
2026-09-09 13:21 ` [PATCH 03/14] mfd: remove unused si476x driver Arnd Bergmann
2026-09-09 13:38 ` sashiko-bot
2026-09-09 13:21 ` [PATCH 04/14] mfd: remove unused wm8400 driver Arnd Bergmann
2026-09-09 13:27 ` Mark Brown
2026-09-09 13:33 ` sashiko-bot
2026-09-09 14:38 ` Charles Keepax
2026-09-09 13:21 ` [PATCH 05/14] mfd: remove unused adp5520 driver Arnd Bergmann
2026-09-09 13:37 ` sashiko-bot
2026-09-09 20:21 ` Arnd Bergmann
2026-09-09 13:21 ` [PATCH 06/14] mfd: remove unused da903x driver Arnd Bergmann
2026-09-09 13:39 ` sashiko-bot
2026-09-09 20:17 ` Arnd Bergmann
2026-09-09 15:46 ` Sebastian Reichel
2026-09-09 13:21 ` [PATCH 07/14] mfd: remove unused lp8788 driver Arnd Bergmann
2026-09-09 13:39 ` sashiko-bot
2026-09-09 20:14 ` Arnd Bergmann
2026-09-09 15:46 ` Sebastian Reichel
2026-09-09 13:21 ` [PATCH 08/14] mfd: remove unused aat2870 driver Arnd Bergmann
2026-09-09 13:30 ` sashiko-bot
2026-09-09 13:21 ` [PATCH 09/14] mfd: remove unused lm3533 driver Arnd Bergmann
2026-09-09 13:35 ` sashiko-bot [this message]
2026-09-09 13:44 ` Johan Hovold
2026-09-09 14:47 ` Arnd Bergmann
2026-09-09 13:21 ` [PATCH 10/14] mfd: remove unused rc5t583 driver Arnd Bergmann
2026-09-09 13:39 ` sashiko-bot
2026-09-09 20:49 ` Arnd Bergmann
2026-09-09 13:48 ` Alexandre Belloni
2026-09-09 13:21 ` [PATCH 11/14] mfd: remove unused wm8350 driver Arnd Bergmann
2026-09-09 13:26 ` Mark Brown
2026-09-09 13:41 ` sashiko-bot
2026-09-09 14:39 ` Charles Keepax
2026-09-09 15:47 ` Sebastian Reichel
2026-09-09 13:21 ` [PATCH 12/14] mfd: remove unused mcp-sa11x0/ucb1x00 driver Arnd Bergmann
2026-09-09 13:48 ` sashiko-bot
2026-09-09 20:53 ` Arnd Bergmann
2026-09-09 13:21 ` [PATCH 13/14] mfd: remove unused menelaus driver Arnd Bergmann
2026-09-09 13:49 ` sashiko-bot
2026-09-09 20:46 ` Arnd Bergmann
2026-09-09 13:51 ` Alexandre Belloni
2026-09-09 13:21 ` [PATCH 14/14] mfd: remove unused iPaq micro driver Arnd Bergmann
2026-09-09 13:43 ` sashiko-bot
2026-09-09 20:58 ` Arnd Bergmann
2026-09-09 14:03 ` [PATCH 00/14] mfd: unused driver purge Bartosz Golaszewski
2026-09-09 17:26 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909133510.E67B61F00A3D@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=media-ci@linuxtv.org \
--cc=mfd@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).