From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DF8CC88E45 for ; Fri, 11 Sep 2026 15:05:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0A4A410F662; Fri, 11 Sep 2026 15:05:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=suse.com header.i=@suse.com header.b="V1BedFKT"; dkim-atps=neutral Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F23310F663 for ; Fri, 11 Sep 2026 15:05:09 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-485850cf499so831712f8f.3 for ; Fri, 11 Sep 2026 08:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1789139108; x=1789743908; darn=lists.freedesktop.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=mniijplyGZlkQZmDrYFnOPglJBLK+WFjfb4odBVk/dg=; b=V1BedFKT64n6GOpbO/JpGOpzLgyIijYwldqwvPoOebpj6iIeiFMgQQ/U/dhWcl3PeJ Mt96cfykNoiyTN6eqLf1dAr7fJqLXmzsX6JEPKKce73UlOgNI1EcCjOqxpIU7iH7B4Rz kagFOG6TzpuxjevUu9p74CFT4ymZUJQegGnsJsbvyE0xh0MpNALTokXy9ibvUrf5UYTV rh/h/d24nzVLYixZFnUZrMktrTsJGxOftpGS6hjMT7hY5EuzuxxszJ9TtffgaA1dT8m5 8d7hw3aa28DFL3oquB9jBfcjbzFbSo+6an32Muzjg/6/Iw0BTT3tIPth2WPV0cGjJczq eYLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789139108; x=1789743908; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=mniijplyGZlkQZmDrYFnOPglJBLK+WFjfb4odBVk/dg=; b=okvqot/z7TRrrBE0ZjQqkChQJASO8dHtXBk9TJ6IJwkoCDLuk0oShhYAYZfiqJQtNW HZaOZQUFZLLNlUqaxLTp0RRvK5+OcGpsP8rLGfJu2iByj/oO4wrwQIGu2O9IIie7b5w2 sZ6Stfkqnd0/LlgcE0cw4NJB0SfXzZIqXOp3qriQvrbWs6qushP0Ssd5eyScEn9mpTOy t+S1ccamwIrzFPZs26aFwEk3Hf4N4zEn6e+W3Q8SduJQKLeF7jGKxcXNgJbsCGFO80la TM4BDW9c12ToSoShL1uFCCA36r0GBjuwM521HlSFq7RHywb/nbse00liEby3yknRPcpz MA5Q== X-Forwarded-Encrypted: i=1; AKwUvBywkaqzePIMUn9xyj3e1nPBebsOQu8WdE3YJbRiet0jzrRBZiYIfJ6tWgVsPAh2ih+k9WeSpySM5dI=@lists.freedesktop.org X-Gm-Message-State: AFuF++nJ37ceQDr/C6er9vnl5dieOaamEEzT3nQbx0r3D1SJEIili3MU rhJEICuK0x1guwjaGYafqMUr2IGzDQPFA5E0A/lJashcGXYuia/3bK+1iT1RbPCw9I0= X-Gm-Gg: AYBFou027GLwT8zz4iyH2ISRnfFSRXu/wU1HeWRvsRhUWj9AJSVoa62+G0skFehFAkO WHh5f66NOEOJeSrLT+hkE9rRaXAKrVYKJrouWawHj/jvKb3XOaU6VAapBYa99bcoTFmIvG5YZ7n zkVc0a+UiT+ev05D6Y2uK8lwYQuoJO806JT4Q2FGHf753cwkuXb8i51txespd/eOBQJgEd0JDzx UDfEOcrEXSFjM6Xcmlhcl9pmysYEeui9wiivChcAhTz/BmskPDk7NQDUTvmTiWdOcF9ZPDV5NiN 8TPt/UjxHp5ULxIqnwwgiuB8Z0XqLJWJ9GoJBe4TYPvooNadvmXNkWVswIm3IcxNLT3aSjNwGz5 Xnoq37NYilVR0IcxwArS3bOt30vVeu8bd2RpjyKCZWDqzmeqWSUqRSsbOWaOhr+UndJZJGzFK/u t+0UV09ZZtrfRqedN9S7eFLC4Hxr+93n+MIqay2EBKBRuV5ngztzsV8bT0D2R5mrnc+7GAFKANK TMDPv8ASXRJtQSJ X-Received: by 2002:adf:ee86:0:b0:485:8c17:975f with SMTP id ffacd0b85a97d-486eb2ffac7mr4035568f8f.33.1789139107698; Fri, 11 Sep 2026 08:05:07 -0700 (PDT) Received: from localhost.localdomain ([2001:af0:8000:1409:193:86:92:181]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-486eb350686sm6853579f8f.27.2026.09.11.08.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Sep 2026 08:05:07 -0700 (PDT) From: Petr Pavlu To: Jens Axboe , Jakub Kicinski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Matthew Brost , =?UTF-8?q?Thomas=20Hellstr=C3=B6m?= Cc: Simon Horman , David Airlie , Simona Vetter , Francois Dugast , Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , linux-block@vger.kernel.org, netdev@vger.kernel.org, linux-api@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/6] Remove the error-injection.h include from linux/module.h Date: Fri, 11 Sep 2026 17:04:00 +0200 Message-ID: <20260911-module-include-error_injection-v1-0-5da895d8c84d@suse.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Change-ID: 20260816-module-include-error_injection-4f80e37a8ea6 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" linux/module.h appears in roughly 15k #include directives across the kernel. This makes it a "hot" header, so it should avoid pulling in unnecessary definitions. The header currently includes linux/error-injection.h to obtain the definition of `struct error_injection_entry`. However, this is unnecessary because the type is only referenced in the file as a pointer, for which an incomplete type is sufficient. Add explicit includes of linux/error-injection.h to files that use the ALLOW_ERROR_INJECTION() macro and currently rely on it being provided indirectly via linux/module.h. Then remove the linux/error-injection.h include from linux/module.h. The first five patches can go through their respective trees if preferred. The final patch depends on the preceding cleanups. --- Petr Pavlu (6): block: Include error-injection.h for ALLOW_ERROR_INJECTION() net: Include error-injection.h for ALLOW_ERROR_INJECTION() syscalls: Include error-injection.h for ALLOW_ERROR_INJECTION() drm/i915: Include error-injection.h for ALLOW_ERROR_INJECTION() drm/xe: Include error-injection.h for ALLOW_ERROR_INJECTION() module: Remove the error-injection.h include from linux/module.h block/blk-core.c | 1 + drivers/gpu/drm/i915/display/intel_connector.c | 1 + drivers/gpu/drm/i915/display/intel_display_driver.c | 1 + drivers/gpu/drm/i915/gt/intel_engine_cs.c | 1 + drivers/gpu/drm/i915/gt/intel_gt.c | 2 ++ drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 1 + drivers/gpu/drm/i915/gt/uc/intel_uc.c | 1 + drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 1 + drivers/gpu/drm/i915/i915_driver.c | 1 + drivers/gpu/drm/i915/i915_pci.c | 2 ++ drivers/gpu/drm/i915/intel_uncore.c | 1 + drivers/gpu/drm/xe/xe_device.c | 2 +- drivers/gpu/drm/xe/xe_exec_queue.c | 1 + drivers/gpu/drm/xe/xe_ggtt.c | 2 +- drivers/gpu/drm/xe/xe_guc.c | 1 + drivers/gpu/drm/xe/xe_guc_ads.c | 2 +- drivers/gpu/drm/xe/xe_guc_ct.c | 2 +- drivers/gpu/drm/xe/xe_guc_log.c | 2 +- drivers/gpu/drm/xe/xe_guc_relay.c | 2 +- drivers/gpu/drm/xe/xe_hw_engine_class_sysfs.c | 1 + drivers/gpu/drm/xe/xe_hw_engine_group.c | 2 ++ drivers/gpu/drm/xe/xe_mmio.c | 1 + drivers/gpu/drm/xe/xe_oa.c | 1 + drivers/gpu/drm/xe/xe_pm.c | 2 +- drivers/gpu/drm/xe/xe_pt.c | 2 ++ drivers/gpu/drm/xe/xe_pxp.c | 2 ++ drivers/gpu/drm/xe/xe_sriov.c | 2 +- drivers/gpu/drm/xe/xe_sync.c | 1 + drivers/gpu/drm/xe/xe_tile.c | 2 +- drivers/gpu/drm/xe/xe_tuning.c | 2 ++ drivers/gpu/drm/xe/xe_uc_fw.c | 2 +- drivers/gpu/drm/xe/xe_vm.c | 1 + drivers/gpu/drm/xe/xe_wa.c | 2 +- drivers/gpu/drm/xe/xe_wopcm.c | 2 +- drivers/net/netdevsim/tc.c | 1 + include/linux/compat.h | 1 + include/linux/module.h | 1 - include/linux/syscalls.h | 1 + kernel/module/main.c | 1 + net/core/skb_fault_injection.c | 1 + 40 files changed, 45 insertions(+), 13 deletions(-) --- base-commit: df2908090cda368b01ff43709f51890076c56157 change-id: 20260816-module-include-error_injection-4f80e37a8ea6