dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Juergen Gross" <jgross@suse.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	linux-hwmon@vger.kernel.org, kvm@vger.kernel.org,
	linux-pci@vger.kernel.org, dri-devel@lists.freedesktop.org,
	dlemoal@kernel.org, linux-ide@vger.kernel.org,
	linux-hyperv@vger.kernel.org, cassel@kernel.org,
	virtualization@lists.linux.dev,
	"Eugenio Perez" <eperezma@redhat.com>,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH v3 12/13] treewide: convert rdmsrq() from a macro to an inline function
Date: Fri, 11 Sep 2026 07:57:53 +0000	[thread overview]
Message-ID: <20260911075753.A3F651F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260911074530.3140830-13-jgross@suse.com>

> Today rdmsrq() is a macro using its second parameter as the target for
> storing the read MSR value.
> 
> Convert rdmsrq() to an inline function returning the MSR value.
> 
> The users have been converted using the following semantic patch:
> 
>   // Options: --include-headers
> 
>   virtual patch
>   virtual report
> 
>   @@
>   expression msr, val;
>   @@
>   (
>   - rdmsrq(msr,val)
>   + val = rdmsrq(msr)
>   )
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260911074530.3140830-1-jgross@suse.com?part=12


  reply	other threads:[~2026-09-11  7:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-11  7:45 [PATCH v3 00/13] x86/msr: Drop 32-bit MSR interfaces Juergen Gross
2026-09-11  7:45 ` [PATCH v3 05/13] agp/nvidia: Stop using " Juergen Gross
2026-09-11  8:04   ` sashiko-bot
2026-09-11  7:45 ` [PATCH v3 06/13] fbdev/geode: " Juergen Gross
2026-09-11  7:45 ` [PATCH v3 12/13] treewide: convert rdmsrq() from a macro to an inline function Juergen Gross
2026-09-11  7:57   ` sashiko-bot [this message]
2026-09-11  9:37   ` Ilpo Järvinen
2026-09-13  5:36     ` Jürgen Groß
2026-09-11 10:11   ` Rafael J. Wysocki (Intel)
2026-09-11 13:22   ` Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260911075753.A3F651F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eperezma@redhat.com \
    --cc=jgross@suse.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=virtualization@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox