From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C70C0C88E4A for ; Fri, 11 Sep 2026 09:50:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3125910E569; Fri, 11 Sep 2026 09:50:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="AbYCAxVL"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id A57A110E61E for ; Fri, 11 Sep 2026 09:50:03 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id C285D60219; Fri, 11 Sep 2026 09:50:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 406861F000FF; Fri, 11 Sep 2026 09:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789120202; bh=YnSJmZaaxbmrEJwi3S5LtU9SWrehkzPV5AyI6o7bX+k=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=AbYCAxVLnTwXyjlF4bW7t4EnKrq+iX2J7JXSwWA7tmB3A0aSIsbPHM3/kUmjCXZPQ QPBXy0FYwRYFpVaUJG/eocYvpSh3wpvUEGB20VcBe/RL/vHBQBKdzh92MJGYlg6yM2 E3+i1AvMreXksAHr2VdhqnUBuXRYGXFW0oCGzKGjial+0UEZQ/YGPYFd3u609LbNBb WMXJG7HfLfglfjrSiE1SbWSrcwoCR5XUhHyAiRhnnLD89AZiPMyxR0lDyiJopbTS9k NaZphUkIGvEmWI6AYGfWnApD6Z593AOrHH2ymYDNVo0AZZeMh7+LYQzqzeuY9XLHUT RSUmNWmjDH74A== From: sashiko-bot@kernel.org Subject: Re: [PATCH 5/5] fbcon: Replace fbcon_fill_cursor_mask() with fbcon_cursor_glyph() To: "Thomas Zimmermann" Cc: linux-serial@vger.kernel.org, dri-devel@lists.freedesktop.org In-Reply-To: <20260911094518.78093-6-tzimmermann@suse.de> References: <20260911094518.78093-1-tzimmermann@suse.de> <20260911094518.78093-6-tzimmermann@suse.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 11 Sep 2026 09:50:01 +0000 Message-Id: <20260911095002.406861F000FF@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > The kernel's font library provides font_glyph_cursor() to create cursor > glyphs. Replace fbcon's fbcon_fill_cursor_mask() with a new helper that > uses font_glyph_cursor(). >=20 > The cursor shapes remain mostly unchanged. The only exception is in > underline cursors for fonts with a size larger than 10. The underlining > dash is now one pixel closer to the font-glyph data, so that the cursor > looks less detached. This follows the style used by vgacon. >=20 > Signed-off-by: Thomas Zimmermann Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260911094518.7809= 3-1-tzimmermann@suse.de?part=3D5