From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84067C88E40 for ; Sun, 13 Sep 2026 09:33:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FF1A10E0CB; Sun, 13 Sep 2026 09:33:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="bnRoxhEi"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4EB4D10E0CB for ; Sun, 13 Sep 2026 09:33:34 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 4B45060AAB; Sun, 13 Sep 2026 09:33:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A66BF1F000FF; Sun, 13 Sep 2026 09:33:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789292012; bh=EpZDcXAbS4SJ/ly1F8xEwrjLvBb9cdg0ItcG60M2Mu8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=bnRoxhEipFWV/QVoMAZ4PDA7YkaDm4+1MWiyL8QRn8W0rdHkyh7mk8m8cystU65/d 5Fl2hKYAeG670n3FrjPnFAAayXHtPTZ27JK9+nDkQjB7vtEmUH25llpDEHaJKcz5Py k+Ie4lGC9lsnqkEfMyzs4ahQhhyWyWOmFgf/wB6StKrXoXfnVNQeWMDHJeJxuK2FEs C2N1Trv+YjGsBa68ZWsDfvcKhJPFper7C7v1R/T7W5RBnm/IAFz3jy55j95pK6KgLh UpAg9sFv0GRkFmyL+XE+0Mxd5pfayUcz3f0ocLesrUKvMcfv9xt8fDadmuL0msCPjH cp7DNFtCMReNg== Date: Sun, 13 Sep 2026 11:33:28 +0200 From: Krzysztof Kozlowski To: Enzo Frese Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Noralf =?utf-8?Q?Tr=C3=B8nnes?= , Neil Armstrong , Jessica Zhang , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: display: panel: mipi-dbi-spi: add st7789v-tft28 Message-ID: <20260913-alluring-outgoing-turtle-fd620e@quoll> References: <20260911201920.72734-1-freseenzo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260911201920.72734-1-freseenzo@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Sep 11, 2026 at 05:19:20PM -0300, Enzo Frese wrote: > This is a generic 2.8" 240x320 RGB LCD panel with a MIPI DBI compatible > SPI interface, based on the Sitronix ST7789V controller. It is commonly > sold by various resellers without an identifiable original manufacturer > name printed on the PCB. > > A basic mipi-dbi-cmd[1] script to get the display running looks like > this: > > $ cat st7789v-tft28.txt > command 0x11 > delay 120 > command 0x3a 0x55 > command 0xb2 0x05 0x05 0x00 0x33 0x33 > command 0xb7 0x75 > command 0xc2 0x01 0xff > command 0xc3 0x13 > command 0xc4 0x20 > command 0xbb 0x22 > command 0xc5 0x20 > command 0xd0 0xa4 0xa1 > command 0xe0 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x44 0x45 0x0f 0x17 0x16 0x2b 0x33 > command 0xe1 0xd0 0x05 0x0a 0x09 0x08 0x05 0x2e 0x43 0x45 0x0f 0x16 0x16 0x2b 0x33 > command 0x36 0x00 > command 0x29 > command 0x21 > > $ mipi-dbi-cmd st7789v-tft28.bin st7789v-tft28.txt > > Tested on a Raspberry Pi 4B using the panel-mipi-dbi driver. > > [1]: https://github.com/notro/panel-mipi-dbi > > Signed-off-by: Enzo Frese > --- > .../devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > index 6f0290c4e291..c28659bd05dc 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-mipi-dbi-spi.yaml > @@ -75,6 +75,7 @@ properties: > - saef,sftc154b > - sainsmart18 > - shineworld,lh133k > + - st7789v-tft28 1. Where is any user of this? Why are you sending binding alone? 2. Does not follow compatible style at all - missing vendor prefix. Best regards, Krzysztof