From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22B0EC88E72 for ; Mon, 14 Sep 2026 22:25:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 75BD010F6D7; Mon, 14 Sep 2026 22:25:11 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="eJmWlPfO"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C51410F6D7 for ; Mon, 14 Sep 2026 22:25:10 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 7773260267; Mon, 14 Sep 2026 22:25:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AFBC1F00893; Mon, 14 Sep 2026 22:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789424709; bh=SF+Wh6RIXHujXtKVmSp2fyGTqjNOayUqu/OXLG8KKSI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=eJmWlPfOaZdbrRg4nnnTG4A9u25SHz/RbsYaG1f1t97yPtOtPfrmZnSYI7CBoQzk4 JbzBI2n9IcLsw1UpbHcxZyKgxWS8FSZicqIJPbIPGZQ9O4T3nliXApn+78mMu89YRC 1s9fa2emo0JnMIFgKqD5un8thT5TBtjTjhLyYsXx8WwJ7CpU7hSObcJkVFd4UG+oww oSzjF2LtfLbKQBgrXPOt+6JMWRFWbwO5VkX7UWBKCdY4fRhddbN/WXgtc9UtPKt2OV CjZsnhjObA64bxQM/W93wQlBhzWwcYXybW4Ejadc/K/XXuvxccX2LxrmE9dsH2nWBW JDmCR6BQ9YVTw== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 40/40] mm/vma: introduce and use vma[_flags]_can_gup() To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: "Vasily Gorbik" , "Marc Zyngier" , linux-perf-users@vger.kernel.org, "Alexander Gordeev" , linux-scsi@vger.kernel.org, dri-devel@lists.freedesktop.org, kvmarm@lists.linux.dev, "Christian Borntraeger" , selinux@vger.kernel.org, "Heiko Carstens" , "Oliver Upton" , kvm@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-trace-kernel@vger.kernel.org, linux-s390@vger.kernel.org In-Reply-To: <20260914-b4-mmap-prepare-vma-flag-sanify-v2-40-7d9781ed5361@kernel.org> References: <20260914-b4-mmap-prepare-vma-flag-sanify-v2-0-7d9781ed5361@kernel.org> <20260914-b4-mmap-prepare-vma-flag-sanify-v2-40-7d9781ed5361@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 14 Sep 2026 22:25:07 +0000 Message-Id: <20260914222508.5AFBC1F00893@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > GUP cannot be used for VMAs which set VMA_IO_BIT - because memory-mapped > I/O must not be accessed on the user's behalf - or VMA_PFNMAP_BIT - becau= se > PFN maps have no folios which the kernel is permitted to access. >=20 > Rather than keeping these checks open-coded, abstract them to > vma_flags_can_gup() and its VMA wrapper vma_can_gup(). >=20 > A number of other places make the same check to decide whether a mapping > can be populated or accessed as GUP would, so update those too. >=20 > While here, drop a reference to 'special' and replace a use of the > deprecated VMA flags API in vma_dump_size(). >=20 > No functional change intended. >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260914-b4-mmap-pr= epare-vma-flag-sanify-v2-0-7d9781ed5361@kernel.org?part=3D40