dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Pet Weng" <pet.weng@ite.com.tw>
Cc: robh@kernel.org, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v10 1/2] dt-bindings: display: Add ITE IT61620 MIPI DSI to HDMI bridge
Date: Tue, 15 Sep 2026 07:36:46 +0000	[thread overview]
Message-ID: <20260915073646.A3C0D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915-it61620-0714-v10-1-738e2a662c06@ite.com.tw>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing maxItems constraint for data-lanes
--

commit 17bcf4f8b4142033bbe40bc85ad49b91b1b814ab
Author: Pet Weng <pet.weng@ite.com.tw>

dt-bindings: display: Add ITE IT61620 MIPI DSI to HDMI bridge

This chip receives MIPI DSI input and outputs HDMI, and is commonly
connected to SoCs via I2C and DSI. IT61620 uses a separate compatible
string from IT6162 due to architectural differences.

> diff --git a/Documentation/devicetree/bindings/display/bridge/ite,it61620.yaml b/Documentation/devicetree/bindings/display/bridge/ite,it61620.yaml
> new file mode 100644
> index 0000000000000..d4f0edeecd0e2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/bridge/ite,it61620.yaml

[ ... ]

> +  ports:
> +    $ref: /schemas/graph.yaml#/properties/ports
> +
> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/$defs/port-base
> +        unevaluatedProperties: false
> +        description: Input port for MIPI DSI
> +
> +        properties:
> +          endpoint:
> +            $ref: /schemas/media/video-interfaces.yaml#
> +            unevaluatedProperties: false
> +            required:
> +              - data-lanes

[Severity: Low]
Should this data-lanes property include a local constraint to enforce the
hardware limit of 4 lanes?

If a user configures a device tree with 5 to 8 lanes, it seems dt_binding_check
will incorrectly accept it. The endpoint schema inherits the generic limit of 8
from video-interfaces.yaml without imposing the local hardware limit.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-it61620-0714-v10-0-738e2a662c06@ite.com.tw?part=1

  reply	other threads:[~2026-09-15  7:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-27  8:02 [PATCH v9 0/2] Add ITE IT61620 MIPI DSI to HDMI bridge driver Pet Weng
2026-03-27  8:02 ` [PATCH v9 1/2] dt-bindings: display: Add ITE IT61620 MIPI DSI to HDMI bridge Pet Weng
2026-03-27  8:02 ` [PATCH v9 2/2] drm/bridge: Add ITE IT61620 MIPI DSI to HDMI bridge driver Pet Weng
2026-09-15  7:26 ` [PATCH v10 0/2] " Pet Weng
2026-09-15  7:26   ` [PATCH v10 1/2] dt-bindings: display: Add ITE IT61620 MIPI DSI to HDMI bridge Pet Weng
2026-09-15  7:36     ` sashiko-bot [this message]
2026-09-15  7:26   ` [PATCH v10 2/2] drm/bridge: Add ITE IT61620 MIPI DSI to HDMI bridge driver Pet Weng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260915073646.A3C0D1F000FF@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=pet.weng@ite.com.tw \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox