From: sashiko-bot@kernel.org
To: "Junrui Luo" <moonafterrain@outlook.com>
Cc: "Eugenio Perez" <eperezma@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
dri-devel@lists.freedesktop.org, virtualization@lists.linux.dev
Subject: Re: [PATCH v2 2/4] drm/virtio: fix object leak in virtio_gpu_resource_create_ioctl()
Date: Tue, 15 Sep 2026 07:48:04 +0000 [thread overview]
Message-ID: <20260915074804.EF9131F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260915-fixes-v2-2-a0d799e4db66@outlook.com>
> From: Junrui Luo <moonafterrain@outlook.com>
>
> virtio_gpu_resource_create_ioctl() calls drm_gem_object_release() on the
> drm_gem_handle_create() error path instead of dropping the reference it
> owns, so obj->funcs->free() never runs and the virtio_gpu_object, its
> pages and sg table, the resource id and the host-side resource are
> leaked.
>
> Use drm_gem_object_put() instead.
>
> Fixes: 62fb7a5e1096 ("virtio-gpu: add 3d/virgl support")
> Assisted-by: Claude:claude-opus-5
> Signed-off-by: Junrui Luo <moonafterrain@outlook.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260915-fixes-v2-0-a0d799e4db66@outlook.com?part=2
next prev parent reply other threads:[~2026-09-15 7:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 7:39 [PATCH v2 0/4] drm/virtio: fix GEM object leaks on error paths Junrui Luo via B4 Relay
2026-09-15 7:39 ` [PATCH v2 1/4] drm/virtio: fix object leak when drm_gem_handle_create() fails Junrui Luo via B4 Relay
2026-09-15 7:46 ` sashiko-bot
2026-09-15 7:39 ` [PATCH v2 2/4] drm/virtio: fix object leak in virtio_gpu_resource_create_ioctl() Junrui Luo via B4 Relay
2026-09-15 7:48 ` sashiko-bot [this message]
2026-09-15 7:39 ` [PATCH v2 3/4] drm/virtio: fix object leaks in virtio_gpu_resource_create_blob_ioctl() Junrui Luo via B4 Relay
2026-09-15 7:48 ` sashiko-bot
2026-09-15 7:39 ` [PATCH v2 4/4] drm/virtio: release the GEM object on virtio_gpu_vram_create() errors Junrui Luo via B4 Relay
2026-09-15 7:50 ` sashiko-bot
2026-09-20 18:18 ` [PATCH v2 0/4] drm/virtio: fix GEM object leaks on error paths Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260915074804.EF9131F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=moonafterrain@outlook.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox