From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7440C982C1 for ; Wed, 16 Sep 2026 07:35:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A611F10E677; Wed, 16 Sep 2026 07:35:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="L9DSTVY7"; dkim-atps=neutral Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7041A10F34D for ; Tue, 15 Sep 2026 08:20:19 +0000 (UTC) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-cc4216aee8fso5333748a12.1 for ; Tue, 15 Sep 2026 01:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1789460419; x=1790065219; darn=lists.freedesktop.org; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date:from:to:cc :subject:date:message-id:reply-to:content-type; bh=3R1bHblX/YSNAoDVuSots2jijK47BJf7ndWg1gXSC20=; b=L9DSTVY7N3KIKTl95TIlV6RkcZGqD/8vkF/ZcDe5N7zxR3IaNsa4anKO3C06faP8Iw gqW/9BwFP7uGw87XwB/NbLmD3+psIqps+Kq9seouVcYqslhScJxv9iqKOCFQMlm8KSfW 4se2jyTQS2png7o0e7BsrU2qwDAVm4rWzYrSH/q50NrYrn1CZHzP7C558NegntemBdZD 4kEr6wKZED+fV4vsRvTDLUbvKRBlVUh7+LRE0fsgC3FH4pQ8WifXAwOMdsqB/8PnlCya /DJ9sFpHbq7/gipCQgTptij0sqyct3JLP1lWY4W1v4wyDI3x4pXxlgxznag5yWNmWYo8 tDtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789460419; x=1790065219; h=content-transfer-encoding:content-type:cc:to:from:subject :message-id:references:mime-version:in-reply-to:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=3R1bHblX/YSNAoDVuSots2jijK47BJf7ndWg1gXSC20=; b=o8OH4eGQNUPN5IDyvsQPFxoEWLM8iESv9M0f6owrYDh8AhfNn1uxH2fLW2yLDX7Ybh EywbujsZEjOxLQsLmU5izDnJIj2KrqEvdoLkwjsgj/FSNxFLjVT/Bl5GM/yW/H3GuK6j NVa7+h5kfa1kPhOQ/IqOmDIRBKqz/qZhxLowvy/2G5U09M2ODkjWehmi3WlzwyBe1WNM +lfeh1PmA+SHl4IUJfNkzM0jSUdU+hNmau3NJhhfDyllyqLmSTydKEX2gw+ZzceQrXTN LPwXWxbS3+mP7EZWtnjC8NwdF4zP7agGhbTyQmnxiIXw7dfrQveikvNPRmEAo+g196Py KcOA== X-Forwarded-Encrypted: i=1; AKwUvBySiwuLMKtQwiQ1gDeGOQwLkNXz/D4crKAssHx+TGFWWelDN/pO77gNmp6CMWSSMa4Ol195CpYSvfs=@lists.freedesktop.org X-Gm-Message-State: AFuF++mIn1DANWAWTPHTlai+BEZTVm+7l62xrKe+CbVDYwkg4n1YaFv+ CoZZ5VJ1srXc/lgfx3kf6AQ6ppA3JhOBI7b9Qn5edkkbEkAcd6PJwlWoq0QRVAQNQpCmfD5Ful3 Y X-Received: from pghu21.prod.google.com ([2002:a63:ef15:0:b0:cc4:da05:ef4c]) (user=morbo job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a21:3315:b0:3d3:aec2:4dcd with SMTP id adf61e73a8af0-3db40623e61mr13262094637.25.1789460418341; Tue, 15 Sep 2026 01:20:18 -0700 (PDT) Date: Tue, 15 Sep 2026 08:18:44 +0000 In-Reply-To: <20260915081910.4142719-1-morbo@google.com> Mime-Version: 1.0 References: <20260915081910.4142719-1-morbo@google.com> X-Mailer: git-send-email 2.55.0.1032.g73a4cd73de-goog Message-ID: <20260915081910.4142719-28-morbo@google.com> Subject: [PATCH 27/28] drm/xe/pf: Convert strlcat() to seq_buf in control_read() From: Bill Wendling To: linux-kernel@vger.kernel.org Cc: Bill Wendling , codemender-patching+linux@google.com, Russell King , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Ian Abbott , H Hartley Sweeten , Tony Luck , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Matthew Brost , "=?UTF-8?q?Thomas=20Hellstr=C3=B6m?=" , Rodrigo Vivi , Dmitry Torokhov , Matthias Schwarzott , Mauro Carvalho Chehab , Tony Nguyen , Przemek Kitszel , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Arend van Spriel , Rob Herring , Saravana Kannan , Krzysztof Kozlowski , Sylwester Nawrocki , Peter Griffin , Alim Akhtar , Linus Walleij , Anil Gurumurthy , Sudarsana Kalluru , "Martin K. Petersen" , Trond Myklebust , Anna Schumaker , Mike Marshall , Martin Brandenburg , Kees Cook , Jiri Pirko , Simon Horman , Chuck Lever , Jeff Layton , NeilBrown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Jaroslav Kysela , Takashi Iwai , Andrew Morton , "Mike Rapoport (Microsoft)" , Kanglong Wang , Tiezhu Yang , Qiang Ma , Randy Dunlap , Pengpeng Hou , Ard Biesheuvel , Breno Leitao , Thorsten Blum , Harshit Mogalapalli , Greg Kroah-Hartman , Lyude Paul , Ashutosh Desai , Imre Deak , Dmitry Baryshkov , Johan Hovold , Johannes Berg , Miri Korenblit , Alexander Stein , Cryolitia PukNgae , Jiaming Zhang , Will Porter , Cen Zhang , "=?UTF-8?q?C=C3=A1ssio=20Gabriel?=" , Rong Zhang , Arun Raghavan , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-edac@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev, brcm80211-dev-list.pdl@broadcom.com, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-scsi@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, linux-hardening@vger.kernel.org, linux-sound@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailman-Approved-At: Wed, 16 Sep 2026 07:35:16 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" control_read() builds a list of supported SR-IOV VF control commands in a stack buffer by calling strlcat() twice per command in a loop. In preparation for removing the deprecated strlcat() API[1], use struct seq_buf and seq_buf_printf() to format each command line and pass seq_buf_used() directly to simple_read_from_buffer(). Link: https://github.com/KSPP/linux/issues/370 [1] Cc: codemender-patching+linux@google.com Assisted-by: CoT-Agent:Gemini-2.0-Flash [editor_update_file, shell_command_= run] Signed-off-by: Bill Wendling --- Cc: Russell King Cc: Huacai Chen Cc: WANG Xuerui Cc: Thomas Bogendoerfer Cc: "James E.J. Bottomley" Cc: Helge Deller Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: x86@kernel.org Cc: "H. Peter Anvin" Cc: Ian Abbott Cc: H Hartley Sweeten Cc: Tony Luck Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: Thomas Zimmermann Cc: David Airlie Cc: Simona Vetter Cc: Matthew Brost Cc: "Thomas Hellstr=C3=B6m" Cc: Rodrigo Vivi Cc: Dmitry Torokhov Cc: Matthias Schwarzott Cc: Mauro Carvalho Chehab Cc: Tony Nguyen Cc: Przemek Kitszel Cc: Andrew Lunn Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Arend van Spriel Cc: Rob Herring Cc: Saravana Kannan Cc: Krzysztof Kozlowski Cc: Sylwester Nawrocki Cc: Peter Griffin Cc: Alim Akhtar Cc: Linus Walleij Cc: Anil Gurumurthy Cc: Sudarsana Kalluru Cc: "Martin K. Petersen" Cc: Trond Myklebust Cc: Anna Schumaker Cc: Mike Marshall Cc: Martin Brandenburg Cc: Kees Cook Cc: Jiri Pirko Cc: Simon Horman Cc: Chuck Lever Cc: Jeff Layton Cc: NeilBrown Cc: Olga Kornievskaia Cc: Dai Ngo Cc: Tom Talpey Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Bill Wendling Cc: Andrew Morton Cc: "Mike Rapoport (Microsoft)" Cc: Kanglong Wang Cc: Tiezhu Yang Cc: Qiang Ma Cc: Randy Dunlap Cc: Pengpeng Hou Cc: Ard Biesheuvel Cc: Breno Leitao Cc: Thorsten Blum Cc: Harshit Mogalapalli Cc: Greg Kroah-Hartman Cc: Lyude Paul Cc: Ashutosh Desai Cc: Imre Deak Cc: Dmitry Baryshkov Cc: Johan Hovold Cc: Johannes Berg Cc: Miri Korenblit Cc: Alexander Stein Cc: Cryolitia PukNgae Cc: Jiaming Zhang Cc: Will Porter Cc: Cen Zhang Cc: "C=C3=A1ssio Gabriel" Cc: Rong Zhang Cc: Arun Raghavan Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: loongarch@lists.linux.dev Cc: linux-mips@vger.kernel.org Cc: linux-parisc@vger.kernel.org Cc: linux-edac@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: intel-xe@lists.freedesktop.org Cc: linux-input@vger.kernel.org Cc: linux-media@vger.kernel.org Cc: intel-wired-lan@lists.osuosl.org Cc: netdev@vger.kernel.org Cc: linux-wireless@vger.kernel.org Cc: brcm80211@lists.linux.dev Cc: brcm80211-dev-list.pdl@broadcom.com Cc: devicetree@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: linux-scsi@vger.kernel.org Cc: linux-nfs@vger.kernel.org Cc: devel@lists.orangefs.org Cc: linux-hardening@vger.kernel.org Cc: linux-sound@vger.kernel.org --- drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c b/drivers/gpu/drm/= xe/xe_gt_sriov_pf_debugfs.c index 0f242db775e1..5db7fc067c4d 100644 --- a/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c +++ b/drivers/gpu/drm/xe/xe_gt_sriov_pf_debugfs.c @@ -4,6 +4,7 @@ */ =20 #include +#include =20 #include #include @@ -663,15 +664,15 @@ static ssize_t control_write(struct file *file, const= char __user *buf, size_t c static ssize_t control_read(struct file *file, char __user *buf, size_t co= unt, loff_t *ppos) { char help[128]; + struct seq_buf s; size_t n; =20 - help[0] =3D '\0'; + seq_buf_init(&s, help, sizeof(help)); for (n =3D 0; n < ARRAY_SIZE(control_cmds); n++) { - strlcat(help, control_cmds[n].cmd, sizeof(help)); - strlcat(help, "\n", sizeof(help)); + seq_buf_printf(&s, "%s\n", control_cmds[n].cmd); } =20 - return simple_read_from_buffer(buf, count, ppos, help, strlen(help)); + return simple_read_from_buffer(buf, count, ppos, help, seq_buf_used(&s)); } =20 static const struct file_operations control_ops =3D { --=20 2.55.0.1032.g73a4cd73de-goog