From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C251C982C1 for ; Wed, 16 Sep 2026 22:35:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B026C10E07D; Wed, 16 Sep 2026 22:35:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.b="REc9T8Tf"; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3ABE410E07D for ; Wed, 16 Sep 2026 22:35:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1789598100; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hyzBhMwpeAjXeWZ8oT+xDx18tHVYCSWsv/6bhvYHBDs=; b=REc9T8TfEH+CYSXF9twBJYijxNKfGDgI/J8/tm61o1yxumvO3YUHWsfPx64ZcLkOJaTlC+ vHbmL4tCKo3Vw+6m6dsnEnHGQ/iiAQwa1vjQYLTvzB48dfaYg4iwli6y5QTXQrS2r7eaBl Wcb76jHNdlAt91b++rc1qdMsqac1gyw= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-2I1OL0sIOLaYKlSWu7kWBQ-1; Wed, 16 Sep 2026 18:34:54 -0400 X-MC-Unique: 2I1OL0sIOLaYKlSWu7kWBQ-1 X-Mimecast-MFC-AGG-ID: 2I1OL0sIOLaYKlSWu7kWBQ_1789598092 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 5C7811800BCC; Wed, 16 Sep 2026 22:34:51 +0000 (UTC) Received: from GoldenWind.redhat.com (unknown [10.22.64.52]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 806B21800577; Wed, 16 Sep 2026 22:34:48 +0000 (UTC) From: Lyude Paul To: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: "Dave Airlie" , "Timur Tabi" , "Andy Shevchenko" , "Mohamed Ahmed" , "Maarten Lankhorst" , "Kees Cook" , "Simona Vetter" , "David Airlie" , "Thomas Zimmermann" , "Maxime Ripard" , "Mel Henning" , "Hongling Zeng" , "Danilo Krummrich" , "Lyude Paul" Subject: [PATCH v4 0/5] drm/nouveau/gsp/r570: Follow OpenRM's runtime PM process more closely Date: Wed, 16 Sep 2026 18:25:04 -0400 Message-ID: <20260916223358.507351-1-lyude@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-MFC-PROC-ID: vj66nfmlYWrc2ZjjR_jaPvX6HtuUp09uze9C-0ymheg_1789598092 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" While we have runtime PM working a lot more reliably then in the past with R570, we're still doing things a lot differently then OpenRM. For instance, we don't save/restore comptag backing stores, and we don't ask GSP whether it's OK to enter GcOff. This series fixes this, and gets our runtime PM process to look a lot closer to OpenRM's by implementing some missing pieces and workarounds. Tested on my daily-driver desktop with an AD102, a ThinkPad P17 Gen1 with a GA103GLM, a Dell Precision 7780 with an AD103, and my test machine with a GB206. Patch series based on drm-misc/drm-misc-next. Branch with patches here: https://gitlab.freedesktop.org/lyudess/linux/-/commits/nouveau/rpm-openrm-sync Previous version: https://patchwork.freedesktop.org/series/173901/ Lyude Paul (5): drm/nouveau/gsp/r535: Add support for INTERNAL_GCX_ENTRY_PREREQUISITE drm/nouveau/gsp/r535: Add support for MEMSYS_GET_STATIC_CONFIG drm/nouveau/gsp/r570: Add comp mode workaround from issue #3172217 drm/nouveau/gsp/r570: Start saving comptag backing stores drm/nouveau/gsp/r570: Enable Gcoff in fbsr again drivers/gpu/drm/nouveau/include/nvif/cl0080.h | 10 +++ drivers/gpu/drm/nouveau/include/nvif/device.h | 1 + .../gpu/drm/nouveau/include/nvkm/subdev/gsp.h | 6 ++ drivers/gpu/drm/nouveau/nouveau_drm.c | 13 ++++ drivers/gpu/drm/nouveau/nvif/device.c | 13 ++++ .../gpu/drm/nouveau/nvkm/engine/device/user.c | 35 +++++++++ .../gpu/drm/nouveau/nvkm/subdev/gsp/base.c | 10 +++ .../gpu/drm/nouveau/nvkm/subdev/gsp/priv.h | 1 + .../drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c | 17 ++++ .../nvkm/subdev/gsp/rm/r535/nvrm/gsp.h | 52 +++++++++++++ .../nouveau/nvkm/subdev/gsp/rm/r570/fbsr.c | 77 ++++++++++++++++++- .../drm/nouveau/nvkm/subdev/gsp/rm/r570/gsp.c | 36 +++++++++ .../nvkm/subdev/gsp/rm/r570/nvrm/fbsr.h | 29 +++++++ .../nvkm/subdev/gsp/rm/r570/nvrm/gsp.h | 7 ++ .../gpu/drm/nouveau/nvkm/subdev/gsp/rm/rm.h | 3 + 15 files changed, 308 insertions(+), 2 deletions(-) base-commit: 5589ef09f93b85b6f506e279a502d4cf1654f232 -- 2.55.0