From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8948DC982D2 for ; Thu, 17 Sep 2026 17:11:13 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 908A310ED85; Thu, 17 Sep 2026 17:11:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ew1yxHMt"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 99EA210ED85 for ; Thu, 17 Sep 2026 17:11:11 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id D41FB60207; Thu, 17 Sep 2026 17:11:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA5DC1F000FF; Thu, 17 Sep 2026 17:11:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789665070; bh=dUVTlcdT8aM+caf/oZ2Aapvv5WbGeHyh5slkxf4lhg4=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ew1yxHMtH056/lzL7meOqpy5eqtMBrXZmNCNZhIm6Aoxqdd01awgXWLBv1PLLYuvP 79oxBIWNZqTicpG1am+T+HJJUXm4umkVWOdZG7ulySslVKl5fWthELadfxctLCBCYJ c91T/sFP9ROZNgN8WzWXdeXDFfjW3eQyO6R8okxZmDwKbSHHr/GITTOPO31RRSNemY frK+ycOu1JoBLnl3UjyeEwDAG3BBG7hpwN73RZrCtslBdMqTuAb2/0tBIuHouEkXQR oVooa4yVaB+w1N+iWEl31/qRkpt9vw43dpuqT6tL1XZR5hUva90o7ksJiwWDSnsVuR LUlZI3J2eGNsQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 03/40] mm/vma: introduce and use vma_[flags_]can_merge() To: =?utf-8?b?TG9yZW56byBTdG9ha2VzIChBUk0p?= Cc: linux-rdma@vger.kernel.org, linux-trace-kernel@vger.kernel.org, "Alexander Gordeev" , selinux@vger.kernel.org, linux-scsi@vger.kernel.org, kvmarm@lists.linux.dev, linux-perf-users@vger.kernel.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, bpf@vger.kernel.org, "Oliver Upton" , "Christian Borntraeger" , kvm@vger.kernel.org, "Heiko Carstens" , "Vasily Gorbik" , "Marc Zyngier" In-Reply-To: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-3-4583d8a23bca@kernel.org> References: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-0-4583d8a23bca@kernel.org> <20260917-b4-mmap-prepare-vma-flag-sanify-v3-3-4583d8a23bca@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Sep 2026 17:11:09 +0000 Message-Id: <20260917171109.BA5DC1F000FF@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > Replace the open-coded VMA_SPECIAL_FLAGS check in the VMA merge logic with > two new functions vma_flags_can_merge() and vma_can_merge() and update the > merge logic to use the former. >=20 > This abstracts the check and expresses it in terms of the desired behavio= ur > rather than an arbitrary and confusing VMA flag. >=20 > This also lays the groundwork for making further improvements in VMA flag > usage. >=20 > Also update the userland VMA tests to reflect the change. >=20 > No functional change intended. >=20 > Signed-off-by: Lorenzo Stoakes (ARM) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260917-b4-mmap-pr= epare-vma-flag-sanify-v3-0-4583d8a23bca@kernel.org?part=3D3