Re: [PATCH v5 2/5] drm/nouveau/gsp/r535: Add support for MEMSYS_GET_STATIC_CONFIG

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] nouveau: missing r535_gsp_get_static_memsys_info() call in r535 init
--

commit ea59a1e02ca1ca9ba089fd374c676d4e85191d91
Author: Lyude Paul <lyude@redhat.com>

drm/nouveau/gsp/r535: Add support for MEMSYS_GET_STATIC_CONFIG

This commit introduces support for MEMSYS_GET_STATIC_CONFIG to fetch memory
management characteristics from the GSP during driver load. It implements the
fetching logic and wires it up for the r570 initialization path.

[ ... ]

> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/gsp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/gsp.c
> index dfda6b0b910a2..dff2081ed764f 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/gsp.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/gsp.c
> @@ -138,6 +138,14 @@ r570_gsp_get_static_info(struct nvkm_gsp *gsp)
>  		}
>  	}
>  
> +	ret = r535_gsp_get_static_memsys_info(gsp);
> +	if (ret) {
> +		nvkm_error(&gsp->subdev, "Retrieving static memsys info failed\n");
> +		return ret;
> +	}
> +	nvkm_debug(&gsp->subdev, "memsys: Use raw mode for comptag allocations? %s\n",
> +		   str_yes_no(gsp->memsys.use_raw_mode_comptagline_alloc));
> +
>  	return 0;
>  }

[Severity: Medium]
Since the commit title explicitly claims to add support for r535, does
r535_gsp_get_static_info() in 
drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r535/gsp.c 
also need to call r535_gsp_get_static_memsys_info()?

Right now, it appears the initialization is only performed in the r570 path.
When loading the nouveau driver on a GPU that uses the r535 GSP firmware,
this leaves gsp->memsys.use_raw_mode_comptagline_alloc uninitialized (false).

Could this create a mismatch and leave internal state incorrectly initialized 
for r535 hardware?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260917170042.440276-1-lyude@redhat.com?part=2