From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CBD16C982D8 for ; Sat, 19 Sep 2026 04:39:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B16C410E4BC; Sat, 19 Sep 2026 04:39:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="gdc0Xb46"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id A386A10E4BC for ; Sat, 19 Sep 2026 04:39:17 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 6CA23601EF; Sat, 19 Sep 2026 04:39:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 551AD1F000FF; Sat, 19 Sep 2026 04:39:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789792756; bh=Igi4RHLJYWAKmVb+cd2dtDK1WqzkkFZ7X+ZVpe9M7cs=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=gdc0Xb46lJVg8B0Ky3G0HTiETukThppICzF4vRLwyqtfTgn+OE2gznNkHPnuVAGJY K9Uxjjwig9JL6g81dNk6F8CBwe2qfsHjEcyYUpyHnEF0QU0XZx3mCcejc9ulWoA73t cUyf5iI7JwQ/Dne01j5S/F9qfVk6I9+TXhLkJI/IF5Ty9oDLe1rOCoL9oDKZFRr5Bz xMXVH3hljWKb0sw+4kVmogm2dnUqqwtWc5EPHrti3+K9eNozLx7YvvhQWh9a14/87S 9whWSzdtS+08iIYTTQm7J1iG6vmO4t1WXjlcB5Tq/vlj8N3R1nj5PSQwgK5lPxgj89 d/EgkVMuN0ntw== Date: Sat, 19 Sep 2026 07:39:11 +0300 From: Leon Romanovsky To: Logan Gunthorpe Cc: Bjorn Helgaas , Chaitanya Kulkarni , Greg Kroah-Hartman , Jens Axboe , Alex Williamson , Ankit Agrawal , Jason Gunthorpe , Jonathan Corbet , Shuah Khan , "Joerg Roedel (AMD)" , Will Deacon , Robin Murphy , Randy Dunlap , Sumit Semwal , Christian =?iso-8859-1?Q?K=F6nig?= , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, iommu@lists.linux.dev, Tushar Dave , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-rdma@vger.kernel.org, kvm@vger.kernel.org, Matt Evans Subject: Re: [PATCH v6 01/18] PCI/P2PDMA: Document pdev->p2pdma lifetime rules Message-ID: <20260919043911.GA13683@unreal> References: <20260914-fix-p2p-acs-v4-0-v6-0-5ef07ec9ef06@nvidia.com> <20260914-fix-p2p-acs-v4-0-v6-1-5ef07ec9ef06@nvidia.com> <6e4f0c2f-eae8-4cd5-9c10-9b9a59941d2f@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6e4f0c2f-eae8-4cd5-9c10-9b9a59941d2f@deltatee.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Sep 18, 2026 at 12:25:01PM -0600, Logan Gunthorpe wrote: > > > On 2026-09-14 05:22, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > pdev->p2pdma is normally accessed through provider-owned references, but > > pci_p2pmem_find_many() and the p2pmem sysfs attributes may race with driver > > unbind. > > > > Document initialization, teardown, and how the release grace period > > protects both the P2PDMA state and its optional allocation pool. > > > > Cc: Alex Williamson > > Cc: Matt Evans > > Signed-off-by: Leon Romanovsky > Reads correct to me. > > Reviewed-by: Logan Gunthorpe Thanks, Logan. Unfortunately, I'm inclined to drop this patch. AI review makes it nearly impossible to write the description without complaints. If I use my own words to describe the lifetime, the tools complain about almost every word or sentence. If I let the tools write it instead, the result is complete junk that merely describes basics already obvious from the code itself. Thanks