From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C53D1C982DA for ; Sun, 20 Sep 2026 19:31:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D89BC10E157; Sun, 20 Sep 2026 19:31:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="On/s1MOg"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7825910E157 for ; Sun, 20 Sep 2026 19:31:07 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1AADB40256; Sun, 20 Sep 2026 19:31:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A66201F00893; Sun, 20 Sep 2026 19:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789932667; bh=XCNtvDG5JB87xvFn9dFADwIRyOll6bbGaUwiajtCl74=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=On/s1MOgtIL/ur5NM6UUWiY4+VwJQPBloN/s9hIABNii9DaogjpMn2oB26LIkA5FR K9kRsy12nvnTQGdSrpe32mgxoQj7JXvI4dPv10IxMW2u8ExYfzFPYKdrefvviKdJEx ze6GE+otKzlMLqe2fjY5kEsooWpkoEC/TA/zDqPIX93rFrN7hwuMLw+1jfE7RYh3uL 53JIjW5SwmHOfoJPr1y8e4efMLV8zaOT7+VJhO0jclY1XCA95d2VGp9xPjJP5d2vGw oW8gbUdEBfCBknQt9MMdbn8UBJv0mZyT7EYtkXPRHMD0432H1oZd64D/nLYHrq7FEj Ntr2e00bjSC6Q== From: sashiko-bot@kernel.org Subject: Re: [PATCH 2/2] drm/virtio: Propagate drm_encoder_init() errors To: "Sebastian von Arx" Cc: "Eugenio Perez" , virtualization@lists.linux.dev, dri-devel@lists.freedesktop.org, "Michael S. Tsirkin" In-Reply-To: <20260920184244.464343-3-linux@sebastianvonarx.ch> References: <20260920184244.464343-1-linux@sebastianvonarx.ch> <20260920184244.464343-3-linux@sebastianvonarx.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 20 Sep 2026 19:31:06 +0000 Message-Id: <20260920193106.A66201F00893@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > vgdev_output_init() ignores errors from drm_encoder_init(), so output > setup continues even when encoder initialization fails, for example > because of an allocation failure. >=20 > Check the return value and propagate the error to the caller. >=20 > Assisted-by: LLM > Signed-off-by: Sebastian von Arx Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260920184244.4643= 43-2-linux@sebastianvonarx.ch?part=3D2