From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 25037C982E6 for ; Mon, 21 Sep 2026 23:31:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4876C88FF9; Mon, 21 Sep 2026 23:31:30 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="CjXqqGto"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 478B910EB35 for ; Mon, 21 Sep 2026 23:31:29 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 5FC1C600CB for ; Mon, 21 Sep 2026 23:31:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2F1E1F000FF; Mon, 21 Sep 2026 23:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790033488; bh=x9lp7gPOH4HN0ABVJ+mnRA/E2DYHcAtL7p17OLva6Sw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=CjXqqGtoH8rNEEO06NNp5LkVdG2N94y96orykZd4hTn63p4zRl3J/8xChcfKps2RZ LgxUqYrmZ9kR5r6tFyo9zKT4ZmvEGvaAqc2r/f7ET89fPQRHvf6H5j4UG8/DFLX85V UXcI32XVY6OxisA/1V0rXkvfwJT/TBt7AqRG6UDQ5CC69rjXUzmD07XUu92bx4sM7x WXI17zvSjWse89uXFwwfelDbf3RsulVbNFOqV5bSxFtzdCI4unYyg/G8f4FYqpYOfo Txx8uMUZFVDBonot0U09nHYTbmQVHlqWp6KIx7y/ysTiHWOmvv1m4XP20RWFGsGVQh xcDBppX+g8EIw== From: sashiko-bot@kernel.org Subject: Re: [PATCH] dt-bindings: panel: Add JDI NT35596S To: =?utf-8?b?Um9iIEhlcnJpbmcgKEFybSk=?= Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, robh@kernel.org In-Reply-To: <20260921232609.3130272-1-robh@kernel.org> References: <20260921232609.3130272-1-robh@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 21 Sep 2026 23:31:27 +0000 Message-Id: <20260921233127.C2F1E1F000FF@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] dt-bindings: incorrect use of additionalProperties instead of uneva= luatedProperties -- commit e0dc4d49c687f6d5568ce2c31031086acb6cd5e6 Author: Rob Herring (Arm) dt-bindings: panel: Add JDI NT35596S This commit adds a new device tree binding schema for the JDI FHD NT35596S MIPI-DSI panel. It documents properties such as the DSI reg value, reset GPIO, backlight, port, and various power supplies. > diff --git a/Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35= 596s.yaml b/Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596= s.yaml > new file mode 100644 > index 0000000000000..aefc9ae5d8abd > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/jdi,fhd-nt35596s.ya= ml [ ... ] > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: jdi,fhd-nt35596s [ ... ] > +required: > + - compatible > + - reg > + - reset-gpios > + - vddio-supply > + - vddneg-supply > + - vddpos-supply > + - port > + > +additionalProperties: false [Severity: Low] Does the use of additionalProperties: false here incorrectly reject standard inherited panel properties? Because this schema references panel-common.yaml in an allOf block, additionalProperties does not traverse the $ref references. This blocks standard properties like rotation and forces the redundant declaration of properties like backlight, reset-gpios, and port just to pass static JSON schema validation during a make dt_binding_check. Should this use unevaluatedProperties: false instead? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260921232609.3130= 272-1-robh@kernel.org?part=3D1