From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC1B6C98302 for ; Tue, 22 Sep 2026 16:06:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 114D810E736; Tue, 22 Sep 2026 16:06:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="OnXG0Zo2"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5520010E736 for ; Tue, 22 Sep 2026 16:06:03 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1BA3D43B88; Tue, 22 Sep 2026 16:06:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C4D261F000FF; Tue, 22 Sep 2026 16:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790093163; bh=JgzbjDEBetEmPW4WJB9+7Tl5maoVhb0P8rs90oyuL+0=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=OnXG0Zo2MnoX5zcrAup4TjC23T/TixRMSzjtJvJXuh3NJOkngrUfDFm84OdQsf/6P VkpfF/Khwqi/RrzJzW+4pS4KLRLoqmB6p4TC0wXNdtsxaLmVGsfOIt5jWKV5NxoTJV 8hRtEiDjSEYOOmmQY73NlYZGMLdyFfruEGKgsqf5Q9/7vyt1hO4GWevuH0fhzVKzrH qPauEQmwHWzchGsqfPhFWdWS7056CcKCmMaZIRt+FKHNup04qoHtcYp2Sp1qDwhXlM 6M7kg+i4y1WK1nF50Gk9SJI6xLjF2jURBYLzJasWwKSB/X7G6aE81fa60wYAfFg2vr 5lixRlIsur+Iw== Date: Tue, 22 Sep 2026 11:06:02 -0500 From: Rob Herring To: Igor Paunovic Cc: Tomeu Vizoso , Oded Gabbay , Heiko Stuebner , Krzysztof Kozlowski , Conor Dooley , Jeff Hugo , Robert Foss , Sidong Yang , Diederik de Haas , Sebastian Reichel , Jiaxing Hu , Nicolas Dufresne , Jonas Karlman , Guangshuo Li , =?iso-8859-1?Q?H=FCseyin?= BIYIK , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 06/11] dt-bindings: npu: rockchip: allow DVFS and thermal properties Message-ID: <20260922160602.GA3529337-robh@kernel.org> References: <20260922080114.44662-1-royalnet026@gmail.com> <20260922080114.44662-7-royalnet026@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260922080114.44662-7-royalnet026@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Sep 22, 2026 at 10:01:09AM +0200, Igor Paunovic wrote: > The three NPU cores on the RK3588 are fed by a single clock and a single > supply, and the firmware accepts a fixed set of rates for that clock. > Describing those rates as an operating-points-v2 table is what lets a > driver scale the NPU instead of leaving it at whatever rate the bootloader > set, so allow the property on the core node. > > Throttling the NPU from a thermal zone needs a core node to be usable as > a cooling device, so allow #cooling-cells too. > > The OPP table belongs on every core, with opp-shared: the cores have no > clock of their own, and one shared table for one shared clock is the same > shape a CPU cluster uses. #cooling-cells goes on one core only, the one a > thermal zone's cooling map names, because the cores cannot be throttled > independently. Naming one representative node for a shared frequency > domain is the established shape, as in "Cpufreq cooling device on CPU0" > in Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml. > > The schema cannot enforce which core carries #cooling-cells, because all > three cores share a compatible string and a node name pattern, so that > stays a devicetree convention. That is the same situation as for CPU > cooling, where cpus.yaml does not restrict #cooling-cells to cpu@0 > either. > > The example gains #cooling-cells; the operating-points-v2 property is > exercised by the RK3588 devicetree later in this series. > > Assisted-by: LLM checkpatch dt_binding_check Drop 'dt_binding_check'. That's expected/assumed. > Signed-off-by: Igor Paunovic > Acked-by: Conor Dooley