From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BDBF6C982FA for ; Tue, 22 Sep 2026 17:20:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E854C10E63F; Tue, 22 Sep 2026 17:20:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="CBoo0Nfj"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id 203D910E63F; Tue, 22 Sep 2026 17:20:22 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 05C50600E2; Tue, 22 Sep 2026 17:20:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 59A721F000FF; Tue, 22 Sep 2026 17:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790097620; bh=HUuOo+GVtPQtBnmmfjEGtqIFoe6CA/D3ljd2+B9VjFM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=CBoo0Nfjp2w2p1+J6maxFpeC0S+ueii/MO/9ei3MnNAcSyGsXRYg+g7TR5Butsg3S +uDejIuopir4HZLVQmasZpPpHQFTd6VE0A2/Ilk3NFQNca+tGHWGn3JnfzUawtFzeQ RCy+dz/pmfc/X0IEC26Sy1nzlhu/66qjMs2slFMstGzqib8vfEPVlh33uPwTGzmEff E9xJQ6/evI74zYi+k8hn3b7LfLP1X2HtgZs6Q8TFYxvFJaHrdME3JlSWEbGqcRJdyz nqRo90kU5f9rLXDRjTB3mVRWWKV/GKPAK4BzInBnVIjFRCXKMJNZHQQZOJVxWoSBHF YG2/wwK4ViVdQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 1/9] mm: introduce hw_pte_t for PTE table storage To: "Muhammad Usama Anjum" Cc: linux-perf-users@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, damon@lists.linux.dev, linux-trace-kernel@vger.kernel.org, bpf@vger.kernel.org In-Reply-To: <20260922-pte0-v3-1-5670b8cb9059@arm.com> References: <20260922-pte0-v3-0-5670b8cb9059@arm.com> <20260922-pte0-v3-1-5670b8cb9059@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 22 Sep 2026 17:20:19 +0000 Message-Id: <20260922172020.59A721F000FF@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > pte_t is used both for software PTE values and for entries stored in a PTE > table, so pte_t * does not distinguish a pointer to a software PTE > value from a pointer to table storage. >=20 > Introduce hw_pte_t as the generic name for a PTE table element. Define it > as a macro alias of pte_t by default. When an architecture selects > ARCH_HAS_HW_PTE_T, define it as a structure containing a pte_t instead. > This preserves the representation while allowing converted architectures > to enforce the distinction at compile time. >=20 > Name the generic wrapper structure __hw_pte_t so architectures can > forward-declare it when pgtable_t must be defined before the generic > hw_pte_t typedef is visible. This avoids header-order dependencies. >=20 > Keep the C type definitions behind an __ASSEMBLY__ check because > architecture assembly sources can include this header indirectly. Include > asm/page.h so consumers such as linux/vmalloc.h retain the page definitio= ns > they previously obtained from that header. >=20 > Acked-by: David Hildenbrand (Arm) > Signed-off-by: Muhammad Usama Anjum Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260922-pte0-v3-0-= 5670b8cb9059@arm.com?part=3D1