From: sashiko-bot@kernel.org
To: yaolu@kylinos.cn
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/amdgpu/pm/powerplay: factor voltage index bounds check into a macro
Date: Wed, 23 Sep 2026 05:46:20 +0000 [thread overview]
Message-ID: <20260923054620.CB42D1F000FF@smtp.kernel.org> (raw)
In-Reply-To: <20260923054111.209370-1-yaolu@kylinos.cn>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] commit message: macro name mismatch PP_CHECK_VOLTAGE_INDEX vs PP_VOLTAGE_INDEX_OOB
--
commit 3d5448c38d3504f9987ca03ae0f6fc0dcde24233
Author: Lu Yao <yaolu@kylinos.cn>
drm/amdgpu/pm/powerplay: factor voltage index bounds check into a macro
This commit refactors duplicate voltage index bounds checking from SMU7 and
Vega10 implementations into a common macro.
> Move the pattern into PP_CHECK_VOLTAGE_INDEX().
[Severity: Low]
This isn't a bug, but the commit message mentions moving the pattern into
PP_CHECK_VOLTAGE_INDEX(), while the code actually defines the macro as
PP_VOLTAGE_INDEX_OOB in drivers/gpu/drm/amd/pm/powerplay/inc/pp_debug.h at
line 58. Could the commit message be updated to reflect the actual macro
name?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260923054111.209370-1-yaolu@kylinos.cn?part=1
prev parent reply other threads:[~2026-09-23 5:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 5:41 [PATCH] drm/amdgpu/pm/powerplay: factor voltage index bounds check into a macro yaolu
2026-09-23 5:46 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923054620.CB42D1F000FF@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=yaolu@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox