Re: [PATCH v3 5/7] dt-bindings: display: allow the boot logo in a reserved memory region

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: oneOf allows partial image properties with memory-region
--

commit 9a7a18d6778dd2101e7f626e61f0b37dcf103451
Author: Max Pedraza <maximpedraza@gmail.com>
Subject: dt-bindings: display: allow the boot logo in a reserved memory region

This commit allows the boot logo to be specified via a reserved memory
region instead of inline properties, enabling the image to be shared across
multiple device trees. It introduces a oneOf constraint intended to make
the two methods mutually exclusive.

> diff --git a/Documentation/devicetree/bindings/display/boot-logo-clut224.yaml b/Documentation/devicetree/bindings/display/boot-logo-clut224.yaml
> index 9dc34717639e9..a71fc09a7c071 100644
> --- a/Documentation/devicetree/bindings/display/boot-logo-clut224.yaml
> +++ b/Documentation/devicetree/bindings/display/boot-logo-clut224.yaml

[ ... ]

> @@ -103,10 +122,17 @@ properties:
>  
>  required:
>    - compatible
> -  - width
> -  - height
> -  - clut
> -  - data
> +
> +# The image either lives in the device tree or in a reserved memory region,
> +# never both.
> +oneOf:
> +  - required:
> +      - width
> +      - height
> +      - clut
> +      - data
> +  - required:
> +      - memory-region

[Severity: Low]
Does this schema validation fully enforce the intended mutual exclusivity if
partial image properties are provided?

If a device tree includes memory-region alongside just a few of the image
properties (for example, accidentally including width and height but not clut),
the first branch of the oneOf evaluates to false. The second branch evaluates
to true. 

Since exactly one branch is true, the overall oneOf constraint succeeds. This
allows invalid device trees with overlapping configurations to silently pass
dt_binding_check.

Should the schema explicitly disallow the other properties when memory-region
is present to prevent this?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260923201035.51007-1-maximpedraza@gmail.com?part=5