Re: [PATCH v2 5/8] arm64: dts: qcom: sm6350-lena: Enable Bluetooth

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing swctrl-gpios schema definition causes dtbs_check failure
--

commit 2895c104a8a87260afe61b3db500946505dbefb6
Author: erebion <erebion@erebion.eu>
Subject: arm64: dts: qcom: sm6350-lena: Enable Bluetooth

Configure the required regulators for Bluetooth and enable it on the
Xperia 10 III.

> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index f3ed6445c7d35..9be0e7ceccb55 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts

[ ... ]

> @@ -424,6 +466,73 @@ ts_int_default: ts-int-default-state {

[ ... ]

> +&uart1 {
> +	/delete-property/ interrupts;
> +	interrupts-extended = <&intc GIC_SPI 602 IRQ_TYPE_LEVEL_HIGH>,
> +			     <&tlmm 64 IRQ_TYPE_EDGE_FALLING>;
> +
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-1 = <&qup_uart1_sleep_cts>, <&qup_uart1_sleep_rts>, <&qup_uart1_sleep_tx>, <&qup_uart1_sleep_rx>;
> +
> +	status = "okay";
> +
> +	bluetooth {
> +		compatible = "qcom,wcn3991-bt";
> +		vddio-supply = <&pm6350_l11>;
> +		vddxo-supply = <&pm6350_l7>;
> +		vddrf-supply = <&pm6150l_l2>;
> +		vddch0-supply = <&pm6150l_l10>;
> +		swctrl-gpios = <&tlmm 69 GPIO_ACTIVE_HIGH>;

[Severity: Low]
Does this property need to be added to the dt-bindings?

When running make dtbs_check, the swctrl-gpios property here fails validation
because it isn't documented in the qcom,wcn3990-bt.yaml schema. Since the
schema enforces unevaluatedProperties: false, the build generates a warning.

The hci_qca driver parses this property correctly at runtime, so there
isn't a functional issue, but should the binding schema be updated to avoid
the validation warning?

> +		firmware-name = "crnv32u.bin";
> +	};
>  };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260926-pdx213-upstream-3-v2-0-b4612e3eb536@erebion.eu?part=5